From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755883Ab0C3Sk5 (ORCPT ); Tue, 30 Mar 2010 14:40:57 -0400 Received: from mail.windriver.com ([147.11.1.11]:55546 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755835Ab0C3Sky (ORCPT ); Tue, 30 Mar 2010 14:40:54 -0400 From: Jason Wessel To: Frederic Weisbecker Cc: linux-kernel@vger.kernel.org, Jason Wessel , Frederic Weisbecker , Ingo Molnar , stable@kernel.org Subject: [PATCH] x86,kgdb: Always initialize the hw breakpoint attribute Date: Tue, 30 Mar 2010 13:39:30 -0500 Message-Id: <1269974370-24831-1-git-send-email-jason.wessel@windriver.com> X-Mailer: git-send-email 1.6.3.1.9.g95405b X-OriginalArrivalTime: 30 Mar 2010 18:39:36.0046 (UTC) FILETIME=[58D328E0:01CAD038] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It is required to call hw_breakpoint_init() on an attr before using it in any other calls. This fixes the problem where kgdb will sometimes fail to initialize on x86_64. CC: Frederic Weisbecker CC: Ingo Molnar CC: stable@kernel.org Signed-off-by: Jason Wessel --- arch/x86/kernel/kgdb.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/x86/kernel/kgdb.c b/arch/x86/kernel/kgdb.c index bfba601..d9adcde 100644 --- a/arch/x86/kernel/kgdb.c +++ b/arch/x86/kernel/kgdb.c @@ -618,6 +618,7 @@ int kgdb_arch_init(void) * portion of kgdb because this operation requires mutexs to * complete. */ + hw_breakpoint_init(&attr); attr.bp_addr = (unsigned long)kgdb_arch_init; attr.type = PERF_TYPE_BREAKPOINT; attr.bp_len = HW_BREAKPOINT_LEN_1; -- 1.6.3.1.9.g95405b