From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E51DA3E8C58 for ; Tue, 10 Mar 2026 07:27:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773127652; cv=none; b=WhfxLcLVUNEsjhmF0JtKtBU1lODh5Y6G23BLDhcKWUS4MSpFObg/d7scjgty9DHHxKQeSZjdfn1S/AZi4xdS7Ye89YF0pl+UwkuDsGnM1ctdmvWqn0ZuqS8NbYPadf4Uy6sGKM4xt0zb3Y53sBRapsteyiR71PJnPpFo4p0NYmk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773127652; c=relaxed/simple; bh=ZFUBXN4vPD2AzDV+RalBsCirmX4aScmxWBdY4ri9AhE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OrEuRMkjM7Vjtp2yeP7+HU/+3tmzdOf504TLS9Id+/Z7ejGMxuddEo7ImEZn6Hgnkmbs6HBK8sEZVyRuqDqeFnwT+DtIFCG/O3rSBVjpnoPNb2MLHRA/v/FQ/y05D4ER1yWZUMCw/EAjCycx3+khuE9Ca/x06hwoklwlcENOJm4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nF2Fi3PI; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OYWE7u/h; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nF2Fi3PI"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OYWE7u/h" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62A6VZro2021721 for ; Tue, 10 Mar 2026 07:27:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 3zx6nX8eJEkJ/dzTTkUQO7iUUXu4TyRs6dnEcBEDUI8=; b=nF2Fi3PI45xErZmb IzIFOrFbLGjbmE0GdqHZ9afch2dtPgYwm3WJFNeqPnYgMkCsnEzqVa7Zx/SjjqI5 2V/bynwfCOY47SMyJkOR778frcUwL/T7s3sQOnKkp4bWkidodvaOaLEGjZmEpIVQ T2Wro5B8eh01k2ZPIgnN4TJNh1kln6eZsfi3rk6i6YHUO55ookOLkpSLJ+3KZlyl aS722vJYOS6zoA1VtEO9FzE3PBbJBuhii6iKHJwLh04XInHiKaRWhXirJNPLOInW /mKwo+SJuEyrhXF5xqHypNtC77MDX9dI40vTozCgMyJzEdtAr8HdVwBSJN+4f5M9 y3ESCg== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cte3w85wx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Mar 2026 07:27:30 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-829a54693edso380761b3a.0 for ; Tue, 10 Mar 2026 00:27:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773127649; x=1773732449; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3zx6nX8eJEkJ/dzTTkUQO7iUUXu4TyRs6dnEcBEDUI8=; b=OYWE7u/hkGZ6mE0h8wQV/wX4c3ne85mAy8XybHzFzTarWiKA3QyQSf3rX6Jkfw2wAx jHktyzSJJUtjKhEO4UBXAXi6ObgMGN9lmYypPfwVinyXar52tF3jKtUfn2/UyL1ih20T lzDQSNU9hrmsbDoNHnZmC9V/q2mjRJcCR4TSKdtmXuVN2kcHqWDkc6q1FmIbdTBBNBQC ksMXuNDZrv9sOKAKd8O56eRVsEKxQ7x2roJaF2Xm10hmhO9ZgBgeZEWOzxLKQ4cp+4kf KX0KfyeWVwsnTgNOmq+l/FuPW5EoiqktBB11pt4rsXzF3aU1BKIWUnNS3WUEJqw8MUe1 BmzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773127649; x=1773732449; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3zx6nX8eJEkJ/dzTTkUQO7iUUXu4TyRs6dnEcBEDUI8=; b=fDV6AmNJKJJop6eGdZlozBqGwtuMSpxmVEFZmi18VahaHl9il2XltD6ibQRlF2LWcV faj8ZwA11FzqfiB5m/qxtI9RjeT2SX5HLdXXh2ZH5ZenOdsEV7/vJYQMj6yKD7AEJBPw Y65IVlnaDe+njfokM/sTgzZFBvNtArtuFf94CkpY8V9j3Dnh/Jsr6ODj05leATS+DPb3 1Edxjzs5xsdk//7aykUvlkm87y/t3OoP4hKaUFYSuyITJYdVeNrDvqCn6rD/w/THKOzI BIJFzq1eIYjkViSMB4h+2txzjx7a9z6UK+WnZOXVFh2pEQQR93niYUqMapLXcgGkrmC2 /dWg== X-Forwarded-Encrypted: i=1; AJvYcCVZm4uyLcUDZS3PLNH7ehGJQsGdMnHNU/xTVdSo+rDam/f8gYzhbEVSoUXsM+o/xeSHQgucsRY0rhc1ATo=@vger.kernel.org X-Gm-Message-State: AOJu0Yx26jzsfUry89FZP1MDvlGS3YdWy1+bhggxsls1E+m1C/4BuqJb nVbf+tNONKjK7Q9MVqqREKoBVu4XijtKUKHjAM6kfgaGG7yXDPHHLQ7eJqctoHW6pNpjN287nmM Sdh6gCoLXZJdAz5rvzpWWZ9DboSKl4WskSsbrGORCYIQSqrnCdgBEiSKME+aYmb0xYWk= X-Gm-Gg: ATEYQzxqzAuRD4EFrp5k06IYlKQgLE5PdPQN5U6Q2rL7JuJn1iFU34phNjyz1txigjJ y3K1enDwlYythdW5VLYbKLIQyKFkiwkkU0A/kQETSE8CC/pSF+lp2Yw+RFxIgFT6DWd4spCerJP 5qfz9UFw11P8WuGFt6puPksAIeDNIhH28fauxWblmL0OlAEN9gcDw+BTUdJoH1caVJOOAFdUKcy cYdWnkZb3evkilqik3sxBB6NqhY4RdCh8wwqXb4hO5+kiRmB5yfDHlCCopZjoKP+5fItFs6E1sx z54eYX9p3rfdT6r0g5C2cYxCN5l2Coq1QZDRdwiuDgp8+1V7/DfgAJ2rcHD8WZilvV3l2hThhS7 Vz9s8UUvxTi1ExxlD5E2125gSTBd+cI+txepiNmrkEMfp0LJCH5NbEd8mPyJshhub/xo9pm6j6P fYlKqEXPfFMM4= X-Received: by 2002:a05:6a00:2282:b0:81e:fd4c:fb39 with SMTP id d2e1a72fcca58-829a2ee9cbbmr8194234b3a.4.1773127649478; Tue, 10 Mar 2026 00:27:29 -0700 (PDT) X-Received: by 2002:a05:6a00:2282:b0:81e:fd4c:fb39 with SMTP id d2e1a72fcca58-829a2ee9cbbmr8194217b3a.4.1773127648919; Tue, 10 Mar 2026 00:27:28 -0700 (PDT) Received: from [10.133.33.95] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-829a48678ccsm11596805b3a.37.2026.03.10.00.27.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Mar 2026 00:27:28 -0700 (PDT) Message-ID: <126b0f41-90e0-4284-ad79-082a61c99f4e@oss.qualcomm.com> Date: Tue, 10 Mar 2026 15:27:25 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: glymur-crd: Enable WLAN and Bluetooth To: Abel Vesa , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260309-glymur-dts-crd-enable-bt-wlan-v1-1-3badbddd5439@oss.qualcomm.com> Content-Language: en-US From: Zijun Hu In-Reply-To: <20260309-glymur-dts-crd-enable-bt-wlan-v1-1-3badbddd5439@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEwMDA2MiBTYWx0ZWRfXzqcklLg0h0jW fDQOJtE/hwPxCNNyiZFq75vRfDVQO1oCIQU3DUDIQf0MIpb3iQ+dILyb4bvauT7b6b3vuAc5e4M jSxPbwj9Y1h6Y9TBgV/vqPn8U2DJ9S2hOcOVUcU3PRs3pdRGJk5Ka7hA+n+itVdL9xM11fxo7Cm 6xadYzgc7Gs5shI0ccNJvEJqfedV8q+CAY+hvX94qw1Cj7Kruxt6yH2ULNOEMxZTVHwve3+l0IZ B40Vh4rEOwTQHBFNL+RghBuPzfDYP6J65xLCpZYAjhuOJHB1zZUF28PLQWaUevjkER2IrO5bAXX 8edeGkJsD620ssvoT9zAPDzbtlpCvVlHfv/cBn46KFSytBixlHqGxpsclMEfjkHYcQhH50CNALZ DX8Tad8W8V25OWAMFEVYOMEticZ9yeDERXZ3w9QwXCQa0yI3GJxCVuT6ovX/Ss6EkhweMSoAKrc HRhDwIaSEJfXx8Z6MSQ== X-Authority-Analysis: v=2.4 cv=GtFPO01C c=1 sm=1 tr=0 ts=69afc7e2 cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=1RLpPmuyo5zqltGQsSoA:9 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-ORIG-GUID: FEStojONHzIhqkYk8Vp83xbT5hBB13D- X-Proofpoint-GUID: FEStojONHzIhqkYk8Vp83xbT5hBB13D- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_01,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 phishscore=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 spamscore=0 suspectscore=0 priorityscore=1501 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603100062 On 3/10/2026 1:33 AM, Abel Vesa wrote: > The Glymur CRD features a WCN7850 WLAN and Bluetooth combo chip. a WCN7850 M.2 WiFi bluetooth combo card. > > So describe both the 0.9V and the 3.3V regulators, then WCN7850 PMU and > the PCIe WLAN and the UART Bluetooth nodes. > > This enables WLAN and Bluetooth functionality on the CRD. > > Signed-off-by: Abel Vesa > --- > arch/arm64/boot/dts/qcom/glymur-crd.dts | 119 ++++++++++++++++++++++++++++++-- > 1 file changed, 113 insertions(+), 6 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/glymur-crd.dts b/arch/arm64/boot/dts/qcom/glymur-crd.dts > index 0de7d35e1148..bcee513e477b 100644 > --- a/arch/arm64/boot/dts/qcom/glymur-crd.dts > +++ b/arch/arm64/boot/dts/qcom/glymur-crd.dts > @@ -190,17 +190,27 @@ vreg_nvmesec: regulator-nvmesec { > regulator-boot-on; > }; > > - vreg_wlan: regulator-wlan { > + vreg_wcn_0p95: regulator-wcn-0p95 { > compatible = "regulator-fixed"; > > - regulator-name = "VREG_WLAN_3P3"; > + regulator-name = "VREG_WCN_0P95"; > + regulator-min-microvolt = <950000>; > + regulator-max-microvolt = <950000>; > + > + vin-supply = <&vreg_wcn_3p3>; > + }; > + > + vreg_wcn_3p3: regulator-wcn-3p3 { > + compatible = "regulator-fixed"; > + > + regulator-name = "VREG_WCN_3P3"; > regulator-min-microvolt = <3300000>; > regulator-max-microvolt = <3300000>; > > gpio = <&tlmm 94 GPIO_ACTIVE_HIGH>; > enable-active-high; > > - pinctrl-0 = <&wlan_reg_en>; > + pinctrl-0 = <&wcn_sw_en>; > pinctrl-names = "default"; > > regulator-boot-on; > @@ -219,6 +229,66 @@ vreg_wwan: regulator-wwan { > pinctrl-0 = <&wwan_reg_en>; > pinctrl-names = "default"; > }; > + > + wcn7850-pmu { > + compatible = "qcom,wcn7850-pmu"; > + > + vdd-supply = <&vreg_wcn_0p95>; > + vddio-supply = <&vreg_l15b_e0_1p8>; > + vddio1p2-supply = <&vreg_l18b_e0_1p2>; may remove vddio1p2-supply since it does NOT use 1.2v IO power supply > + vddaon-supply = <&vreg_l15b_e0_1p8>; > + vdddig-supply = <&vreg_l15b_e0_1p8>; > + vddrfa1p2-supply = <&vreg_l15b_e0_1p8>; > + vddrfa1p8-supply = <&vreg_l15b_e0_1p8>; > + > + wlan-enable-gpios = <&tlmm 117 GPIO_ACTIVE_HIGH>; > + bt-enable-gpios = <&tlmm 116 GPIO_ACTIVE_HIGH>; > + > + pinctrl-0 = <&wcn_wlan_bt_en>; > + pinctrl-names = "default"; > + > + regulators { > + vreg_pmu_rfa_cmn: ldo0 { > + regulator-name = "vreg_pmu_rfa_cmn"; > + }; > + > + vreg_pmu_aon_0p59: ldo1 { > + regulator-name = "vreg_pmu_aon_0p59"; > + }; > + > + vreg_pmu_wlcx_0p8: ldo2 { > + regulator-name = "vreg_pmu_wlcx_0p8"; > + }; > + > + vreg_pmu_wlmx_0p85: ldo3 { > + regulator-name = "vreg_pmu_wlmx_0p85"; > + }; > + > + vreg_pmu_btcmx_0p85: ldo4 { > + regulator-name = "vreg_pmu_btcmx_0p85"; > + }; > + > + vreg_pmu_rfa_0p8: ldo5 { > + regulator-name = "vreg_pmu_rfa_0p8"; > + }; > + > + vreg_pmu_rfa_1p2: ldo6 { > + regulator-name = "vreg_pmu_rfa_1p2"; > + }; > + > + vreg_pmu_rfa_1p8: ldo7 { > + regulator-name = "vreg_pmu_rfa_1p8"; > + }; > + > + vreg_pmu_pcie_0p9: ldo8 { > + regulator-name = "vreg_pmu_pcie_0p9"; > + }; > + > + vreg_pmu_pcie_1p8: ldo9 { > + regulator-name = "vreg_pmu_pcie_1p8"; > + }; > + }; > + }; > }; > > &apps_rsc { > @@ -616,8 +686,6 @@ &pcie3b_port0 { > }; > > &pcie4 { > - vddpe-3v3-supply = <&vreg_wlan>; > - Ack. > pinctrl-0 = <&pcie4_default>; > pinctrl-names = "default"; > > @@ -634,6 +702,21 @@ &pcie4_phy { > &pcie4_port0 { > reset-gpios = <&tlmm 146 GPIO_ACTIVE_LOW>; > wake-gpios = <&tlmm 148 GPIO_ACTIVE_LOW>; > + > + wifi@0 { > + compatible = "pci17cb,1107"; > + reg = <0x10000 0x0 0x0 0x0 0x0>; > + > + vddaon-supply = <&vreg_pmu_aon_0p59>; > + vddwlcx-supply = <&vreg_pmu_wlcx_0p8>; > + vddwlmx-supply = <&vreg_pmu_wlmx_0p85>; > + vddrfacmn-supply = <&vreg_pmu_rfa_cmn>; > + vddrfa0p8-supply = <&vreg_pmu_rfa_0p8>; > + vddrfa1p2-supply = <&vreg_pmu_rfa_1p2>; > + vddrfa1p8-supply = <&vreg_pmu_rfa_1p8>; > + vddpcie0p9-supply = <&vreg_pmu_pcie_0p9>; > + vddpcie1p8-supply = <&vreg_pmu_pcie_1p8>; > + }; > }; > > &pcie5 { > @@ -873,7 +956,14 @@ wake-n-pins { > }; > }; > > - wlan_reg_en: wlan-reg-en-state { > + wcn_wlan_bt_en: wcn-wlan-bt-en-state { > + pins = "gpio116", "gpio117"; > + function = "gpio"; > + drive-strength = <2>; > + bias-disable; > + }; > + > + wcn_sw_en: wcn-sw-en-state { > pins = "gpio94"; > function = "gpio"; > drive-strength = <2>; > @@ -888,6 +978,23 @@ wwan_reg_en: wwan-reg-en-state { > }; > }; > > +&uart14 { > + status = "okay"; > + > + bluetooth { > + compatible = "qcom,wcn7850-bt"; > + max-speed = <3200000>; > + > + vddaon-supply = <&vreg_pmu_aon_0p59>; > + vddwlcx-supply = <&vreg_pmu_wlcx_0p8>; > + vddwlmx-supply = <&vreg_pmu_wlmx_0p85>; > + vddrfacmn-supply = <&vreg_pmu_rfa_cmn>; > + vddrfa0p8-supply = <&vreg_pmu_rfa_0p8>; > + vddrfa1p2-supply = <&vreg_pmu_rfa_1p2>; > + vddrfa1p8-supply = <&vreg_pmu_rfa_1p8>; > + }; > +}; > + > &usb_0 { > dr_mode = "host"; > > > --- > base-commit: 5138081b838d92e1bfcddc7b72b9215cca6e83f0 > change-id: 20260309-glymur-dts-crd-enable-bt-wlan-db90c414ebaa > prerequisite-change-id: 20260109-dts-qcom-glymur-add-usb-support-617b6d9d032c:v4 > prerequisite-patch-id: df42484b224c01014637ec5a8f56bab459890557 > prerequisite-patch-id: d986d8d948eaf7b80028b2244750dc7aff7de307 > prerequisite-patch-id: 7ec5f802a334d96421d8f95d4d9e9773655cc947 > prerequisite-patch-id: 8d9e016b49979fa817cf9eab70b809fdb9d4656f > prerequisite-change-id: 20260109-dts-qcom-glymur-crd-add-edp-03f0adde9750:v4 > prerequisite-patch-id: df42484b224c01014637ec5a8f56bab459890557 > prerequisite-patch-id: d986d8d948eaf7b80028b2244750dc7aff7de307 > prerequisite-patch-id: 7ec5f802a334d96421d8f95d4d9e9773655cc947 > prerequisite-patch-id: 8d9e016b49979fa817cf9eab70b809fdb9d4656f > prerequisite-patch-id: 6a291fd702870ca28d64439313d498593996b741 > prerequisite-patch-id: c96958ab5c5605fb9577645ac5bfe5912cdfebfe > prerequisite-patch-id: bfa283218723a48e54fcd842484b004c877339b7 > prerequisite-patch-id: 346f2db0933c551a039f63b945f989a5c8320657 > prerequisite-patch-id: 919020405b70d588fa4356a5cbfb44e67006102e > > Best regards, > -- > Abel Vesa >