From: Borislav Petkov <bp@amd64.org>
To: <hpa@zytor.com>, <mingo@elte.hu>, <tglx@linutronix.de>,
<akpm@linux-foundation.org>
Cc: davej@redhat.com, trenn@suse.de, linux@dominikbrodowski.net,
cpufreq@vger.kernel.org, <linux-kernel@vger.kernel.org>,
<x86@kernel.org>
Subject: [PATCH 3/6] x86: Unify APERF/MPERF support
Date: Wed, 31 Mar 2010 21:56:43 +0200 [thread overview]
Message-ID: <1270065406-1814-4-git-send-email-bp@amd64.org> (raw)
In-Reply-To: <1270065406-1814-1-git-send-email-bp@amd64.org>
From: Borislav Petkov <borislav.petkov@amd.com>
Initialize this CPUID flag feature in common code. It could be made a
standalone function later, maybe, if more functionality is duplicated.
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
Reviewed-by: Thomas Renninger <trenn@suse.de>
---
arch/x86/kernel/cpu/addon_cpuid_features.c | 8 ++++++++
arch/x86/kernel/cpu/intel.c | 6 ------
2 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/arch/x86/kernel/cpu/addon_cpuid_features.c b/arch/x86/kernel/cpu/addon_cpuid_features.c
index ead2a1c..fd1fc19 100644
--- a/arch/x86/kernel/cpu/addon_cpuid_features.c
+++ b/arch/x86/kernel/cpu/addon_cpuid_features.c
@@ -54,6 +54,14 @@ void __cpuinit init_scattered_cpuid_features(struct cpuinfo_x86 *c)
if (regs[cb->reg] & (1 << cb->bit))
set_cpu_cap(c, cb->feature);
}
+
+ /*
+ * common AMD/Intel features
+ */
+ if (c->cpuid_level >= 6) {
+ if (cpuid_ecx(6) & 0x1)
+ set_cpu_cap(c, X86_FEATURE_APERFMPERF);
+ }
}
/* leaf 0xb SMT level */
diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c
index 7e1cca1..3830258 100644
--- a/arch/x86/kernel/cpu/intel.c
+++ b/arch/x86/kernel/cpu/intel.c
@@ -352,12 +352,6 @@ static void __cpuinit init_intel(struct cpuinfo_x86 *c)
set_cpu_cap(c, X86_FEATURE_ARCH_PERFMON);
}
- if (c->cpuid_level > 6) {
- unsigned ecx = cpuid_ecx(6);
- if (ecx & 0x01)
- set_cpu_cap(c, X86_FEATURE_APERFMPERF);
- }
-
if (cpu_has_xmm2)
set_cpu_cap(c, X86_FEATURE_LFENCE_RDTSC);
if (cpu_has_ds) {
--
1.7.0
next prev parent reply other threads:[~2010-03-31 19:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-31 19:56 [-v3 PATCH 0/6] powernow-k8: Core Performance Boost and effective frequency support Borislav Petkov
2010-03-31 19:56 ` [PATCH 1/6] x86, cpu: Add AMD core boosting feature flag to /proc/cpuinfo Borislav Petkov
2010-04-09 22:18 ` [tip:x86/cpu] " tip-bot for Borislav Petkov
2010-03-31 19:56 ` [PATCH 2/6] powernow-k8: Add core performance boost support Borislav Petkov
2010-04-09 22:19 ` [tip:x86/cpu] " tip-bot for Borislav Petkov
2010-03-31 19:56 ` Borislav Petkov [this message]
2010-04-09 22:19 ` [tip:x86/cpu] x86: Unify APERF/MPERF support tip-bot for Borislav Petkov
2010-05-03 23:21 ` [tip:x86/cpu] x86, cpu: Make APERF/MPERF a normal table-driven flag tip-bot for H. Peter Anvin
2010-03-31 19:56 ` [PATCH 4/6] cpufreq: Add APERF/MPERF support for AMD processors Borislav Petkov
2010-04-01 9:01 ` Marvin
2010-04-01 10:36 ` Borislav Petkov
2010-04-01 11:46 ` Marvin
2010-04-01 14:00 ` Borislav Petkov
2010-04-01 14:19 ` [-v3.1 PATCH " Borislav Petkov
2010-04-09 22:19 ` [tip:x86/cpu] x86, " tip-bot for Mark Langsdorf
2010-03-31 19:56 ` [PATCH 5/6] powernow-k8: Fix frequency reporting Borislav Petkov
2010-04-09 22:19 ` [tip:x86/cpu] " tip-bot for Mark Langsdorf
2010-05-03 13:09 ` [tip:x86/urgent] " tip-bot for Mark Langsdorf
2010-03-31 19:56 ` [PATCH 6/6] cpufreq: Unify sysfs attribute definition macros Borislav Petkov
2010-04-09 22:20 ` [tip:x86/cpu] " tip-bot for Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1270065406-1814-4-git-send-email-bp@amd64.org \
--to=bp@amd64.org \
--cc=akpm@linux-foundation.org \
--cc=cpufreq@vger.kernel.org \
--cc=davej@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=trenn@suse.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®