From: Matt McCutchen <matt@mattmccutchen.net>
To: ReiserFS Mailing List <reiserfs-devel@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Edward Shishkin <edward.shishkin@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Jeff Mahoney <jeffm@suse.com>
Subject: Re: [PATCH #3] reiserfs: Fix permissions on .reiserfs_priv
Date: Thu, 08 Apr 2010 18:39:27 -0400 [thread overview]
Message-ID: <1270766367.3441.4.camel@mattlaptop2.local> (raw)
In-Reply-To: <4BBE4CE2.8030805@gmail.com>
On Thu, 2010-04-08 at 23:38 +0200, Edward Shishkin wrote:
> Jeff Mahoney wrote:
> > [...] This patch resolves the issue by properly hiding .reiserfs_priv. This
> > was the intent of the xattr poisoning code, but it appears to have
> > never worked as expected. This is fixed by using d_revalidate instead
> > of d_compare. [...]
The patch seems to rely on the fact that the priv_root dentry is stuck
in the dcache for as long as the filesystem is mounted, so that attempts
to follow ".reiserfs_priv" are guaranteed to match that dentry in the
cache and be refused by xattr_hide_revalidate. Is my understanding
correct?
--
Matt
next prev parent reply other threads:[~2010-04-08 22:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-08 20:55 Jeff Mahoney
2010-04-08 21:38 ` Edward Shishkin
2010-04-08 22:39 ` Matt McCutchen [this message]
2010-04-09 0:04 ` Jeff Mahoney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1270766367.3441.4.camel@mattlaptop2.local \
--to=matt@mattmccutchen.net \
--cc=akpm@linux-foundation.org \
--cc=edward.shishkin@gmail.com \
--cc=jeffm@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=reiserfs-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome