mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Woodhouse <david.woodhouse@intel.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
	Chris Wright <chrisw@sous-sol.org>,
	"Yu, Fenghua" <fenghua.yu@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>
Subject: Re: [PATCH 1/6] pci/dmar: Don't complain that IOPAIC is not supported
Date: Fri, 09 Apr 2010 16:33:35 +0100	[thread overview]
Message-ID: <1270827215.4478.10436.camel@macbook.infradead.org> (raw)
In-Reply-To: <1270753107-15881-2-git-send-email-yinghai@kernel.org>

On Thu, 2010-04-08 at 19:58 +0100, Yinghai Lu wrote:
> INTR_REMAP handle that type, so if that is used, we should not complain that
> 
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
> ---
>  drivers/pci/dmar.c |   10 +++++++---
>  1 files changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/pci/dmar.c b/drivers/pci/dmar.c
> index 33ead97..3bd013f 100644
> --- a/drivers/pci/dmar.c
> +++ b/drivers/pci/dmar.c
> @@ -131,9 +131,13 @@ static int __init dmar_parse_dev_scope(void *start, void *end, int *cnt,
>  		if (scope->entry_type == ACPI_DMAR_SCOPE_TYPE_ENDPOINT ||
>  		    scope->entry_type == ACPI_DMAR_SCOPE_TYPE_BRIDGE)
>  			(*cnt)++;
> -		else
> -			printk(KERN_WARNING PREFIX
> -				"Unsupported device scope\n");
> +		else  {
> +#ifdef CONFIG_INTR_REMAP
> +			if (scope->entry_type != ACPI_DMAR_SCOPE_TYPE_IOAPIC)
> +#endif
> +				printk(KERN_WARNING PREFIX
> +					"Unsupported device scope\n");
> +		}
>  		start += scope->length;
>  	}
>  	if (*cnt == 0)

Applied, without the ifdef and slightly cleaned up.

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@intel.com                              Intel Corporation


  reply	other threads:[~2010-04-09 15:33 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-08 18:58 [PATCH 0/6] pci/dmar: small cleanup Yinghai Lu
2010-04-08 18:58 ` [PATCH 1/6] pci/dmar: Don't complain that IOPAIC is not supported Yinghai Lu
2010-04-09 15:33   ` David Woodhouse [this message]
2010-04-08 18:58 ` [PATCH 2/6] pci/dmar: Print out iommu seq_id Yinghai Lu
2010-04-08 18:58 ` [PATCH 3/6] pci/dmar: remove the noisy print out about unmapping Yinghai Lu
2010-04-09 15:34   ` David Woodhouse
2010-04-08 18:58 ` [PATCH 4/6] pci/dmar/sriov: use physfn to search drhd for VF Yinghai Lu
2010-04-08 19:10   ` Roland Dreier
2010-04-08 20:52     ` Yinghai
2010-04-08 20:56       ` Roland Dreier
2010-04-08 23:24       ` Chris Wright
2010-04-09  0:07         ` Yinghai
2010-04-09  0:16           ` Chris Wright
2010-04-09 15:54           ` Jesse Barnes
2010-04-08 18:58 ` [PATCH 5/6] pci/dmar: Fix link warning Yinghai Lu
2010-04-08 19:31   ` Chris Wright
2010-04-08 18:58 ` [PATCH 6/6] intel-iommu: Don't call domain_exit if can not attach with iommu Yinghai Lu
2010-04-09 15:43   ` David Woodhouse
2010-04-09 17:49     ` Yinghai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1270827215.4478.10436.camel@macbook.infradead.org \
    --to=david.woodhouse@intel.com \
    --cc=chrisw@sous-sol.org \
    --cc=fenghua.yu@intel.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®