mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Alasdair G Kergon <agk@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Arnd Bergmann <arnd@relay.de.ibm.com>,
	Arnd Bergmann <arnd@arndb.de>, Alasdair G Kergon <agk@redhat.com>,
	Frederic Weisbecker <fweisbec@gmail.com>
Subject: [PATCH] dm: Use nonseekable_open
Date: Sat, 10 Apr 2010 16:58:50 +0200	[thread overview]
Message-ID: <1270911530-9455-1-git-send-regression-fweisbec@gmail.com> (raw)

From: Arnd Bergmann <arnd@relay.de.ibm.com>

The dm control device does not implement read/write, so it has
no use for seeking. Using no_llseek prevents falling back to
default_llseek, which requires the BKL.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Alasdair G Kergon <agk@redhat.com>
[drop useless llseek = no_llseek]
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
---
 drivers/md/dm-ioctl.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioctl.c
index d7500e1..78b28eb 100644
--- a/drivers/md/dm-ioctl.c
+++ b/drivers/md/dm-ioctl.c
@@ -1593,6 +1593,7 @@ static long dm_compat_ctl_ioctl(struct file *file, uint command, ulong u)
 #endif
 
 static const struct file_operations _ctl_fops = {
+	.open = nonseekable_open,
 	.unlocked_ioctl	 = dm_ctl_ioctl,
 	.compat_ioctl = dm_compat_ctl_ioctl,
 	.owner	 = THIS_MODULE,
-- 
1.6.2.3


                 reply	other threads:[~2010-04-10 14:58 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1270911530-9455-1-git-send-regression-fweisbec@gmail.com \
    --to=fweisbec@gmail.com \
    --cc=agk@redhat.com \
    --cc=arnd@arndb.de \
    --cc=arnd@relay.de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®