From: Glauber Costa <glommer@redhat.com>
To: kvm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, avi@redhat.com
Subject: [PATCH 2/5] change msr numbers for kvmclock
Date: Thu, 15 Apr 2010 14:37:25 -0400 [thread overview]
Message-ID: <1271356648-5108-3-git-send-email-glommer@redhat.com> (raw)
In-Reply-To: <1271356648-5108-2-git-send-email-glommer@redhat.com>
Avi pointed out a while ago that those MSRs falls into the pentium
PMU range. So the idea here is to add new ones, and after a while,
deprecate the old ones.
Signed-off-by: Glauber Costa <glommer@redhat.com>
---
arch/x86/include/asm/kvm_para.h | 8 ++++++--
arch/x86/kvm/x86.c | 7 ++++++-
2 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/arch/x86/include/asm/kvm_para.h b/arch/x86/include/asm/kvm_para.h
index ffae142..0cffb96 100644
--- a/arch/x86/include/asm/kvm_para.h
+++ b/arch/x86/include/asm/kvm_para.h
@@ -17,8 +17,12 @@
#define KVM_FEATURE_NOP_IO_DELAY 1
#define KVM_FEATURE_MMU_OP 2
-#define MSR_KVM_WALL_CLOCK 0x11
-#define MSR_KVM_SYSTEM_TIME 0x12
+#define MSR_KVM_WALL_CLOCK_OLD 0x11
+#define MSR_KVM_SYSTEM_TIME_OLD 0x12
+
+/* Custom MSRs falls in the range 0x4b564d00-0x4b564dff */
+#define MSR_KVM_WALL_CLOCK 0x4b564d00
+#define MSR_KVM_SYSTEM_TIME 0x4b564d01
#define KVM_MAX_MMU_OP_BATCH 32
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 8824b73..714aae2 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -575,9 +575,10 @@ static inline u32 bit(int bitno)
* kvm-specific. Those are put in the beginning of the list.
*/
-#define KVM_SAVE_MSRS_BEGIN 5
+#define KVM_SAVE_MSRS_BEGIN 7
static u32 msrs_to_save[] = {
MSR_KVM_SYSTEM_TIME, MSR_KVM_WALL_CLOCK,
+ MSR_KVM_SYSTEM_TIME_OLD, MSR_KVM_WALL_CLOCK_OLD,
HV_X64_MSR_GUEST_OS_ID, HV_X64_MSR_HYPERCALL,
HV_X64_MSR_APIC_ASSIST_PAGE,
MSR_IA32_SYSENTER_CS, MSR_IA32_SYSENTER_ESP, MSR_IA32_SYSENTER_EIP,
@@ -1099,10 +1100,12 @@ int kvm_set_msr_common(struct kvm_vcpu *vcpu, u32 msr, u64 data)
case MSR_IA32_MISC_ENABLE:
vcpu->arch.ia32_misc_enable_msr = data;
break;
+ case MSR_KVM_WALL_CLOCK_OLD:
case MSR_KVM_WALL_CLOCK:
vcpu->kvm->arch.wall_clock = data;
kvm_write_wall_clock(vcpu->kvm, data);
break;
+ case MSR_KVM_SYSTEM_TIME_OLD:
case MSR_KVM_SYSTEM_TIME: {
if (vcpu->arch.time_page) {
kvm_release_page_dirty(vcpu->arch.time_page);
@@ -1374,9 +1377,11 @@ int kvm_get_msr_common(struct kvm_vcpu *vcpu, u32 msr, u64 *pdata)
data = vcpu->arch.efer;
break;
case MSR_KVM_WALL_CLOCK:
+ case MSR_KVM_WALL_CLOCK_OLD:
data = vcpu->kvm->arch.wall_clock;
break;
case MSR_KVM_SYSTEM_TIME:
+ case MSR_KVM_SYSTEM_TIME_OLD:
data = vcpu->arch.time;
break;
case MSR_IA32_P5_MC_ADDR:
--
1.6.2.2
next prev parent reply other threads:[~2010-04-15 18:39 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-15 18:37 [PATCH 0/5] pv clock misc fixes Glauber Costa
2010-04-15 18:37 ` [PATCH 1/5] Add a global synchronization point for pvclock Glauber Costa
2010-04-15 18:37 ` Glauber Costa [this message]
2010-04-15 18:37 ` [PATCH 3/5] Try using new kvm clock msrs Glauber Costa
2010-04-15 18:37 ` [PATCH 4/5] export new cpuid KVM_CAP Glauber Costa
2010-04-15 18:37 ` [PATCH 5/5] add documentation about kvmclock Glauber Costa
2010-04-15 19:28 ` Randy Dunlap
2010-04-15 20:10 ` Glauber Costa
2010-04-17 18:58 ` [PATCH 4/5] export new cpuid KVM_CAP Avi Kivity
2010-04-19 14:50 ` Glauber Costa
2010-04-20 9:29 ` Avi Kivity
2010-04-17 18:55 ` [PATCH 3/5] Try using new kvm clock msrs Avi Kivity
2010-04-17 18:51 ` [PATCH 2/5] change msr numbers for kvmclock Avi Kivity
2010-04-16 20:23 ` [PATCH 1/5] Add a global synchronization point for pvclock Marcelo Tosatti
2010-04-16 20:36 ` Jeremy Fitzhardinge
2010-04-16 21:05 ` Zachary Amsden
2010-04-19 10:39 ` Peter Zijlstra
2010-04-19 10:50 ` Avi Kivity
2010-04-19 11:05 ` Peter Zijlstra
2010-04-19 11:10 ` Avi Kivity
2010-04-19 14:21 ` Glauber Costa
2010-04-19 14:33 ` Avi Kivity
2010-04-19 14:46 ` Peter Zijlstra
2010-04-19 16:18 ` Jeremy Fitzhardinge
2010-04-20 9:31 ` Avi Kivity
2010-04-20 18:23 ` Jeremy Fitzhardinge
2010-04-20 18:54 ` Avi Kivity
2010-04-20 19:42 ` Jeremy Fitzhardinge
2010-04-21 0:07 ` Zachary Amsden
2010-04-22 13:11 ` Glauber Costa
2010-04-23 1:44 ` Zachary Amsden
2010-04-23 9:34 ` Avi Kivity
2010-04-23 19:22 ` Jeremy Fitzhardinge
2010-04-23 19:25 ` Avi Kivity
2010-04-23 21:31 ` Zachary Amsden
2010-04-23 21:35 ` Jeremy Fitzhardinge
2010-04-23 21:41 ` Zachary Amsden
2010-04-24 9:30 ` Avi Kivity
2010-04-24 9:29 ` Avi Kivity
2010-04-19 16:11 ` Jeremy Fitzhardinge
2010-04-19 14:26 ` Glauber Costa
2010-04-19 16:19 ` Jeremy Fitzhardinge
2010-04-19 18:25 ` Glauber Costa
2010-04-20 1:57 ` Marcelo Tosatti
2010-04-20 9:35 ` Avi Kivity
2010-04-20 12:59 ` Glauber Costa
2010-04-20 15:16 ` Avi Kivity
2010-04-21 0:01 ` Zachary Amsden
2010-04-21 8:06 ` Avi Kivity
2010-04-17 18:48 ` Avi Kivity
2010-04-17 18:49 ` Avi Kivity
2010-04-19 10:43 ` Peter Zijlstra
2010-04-19 10:47 ` Avi Kivity
2010-04-19 10:56 ` Peter Zijlstra
2010-04-19 11:13 ` Avi Kivity
2010-04-19 11:19 ` Peter Zijlstra
2010-04-19 11:40 ` Avi Kivity
2010-04-19 14:32 ` Glauber Costa
2010-04-19 14:37 ` Avi Kivity
2010-04-19 10:46 ` Peter Zijlstra
2010-04-19 10:49 ` Avi Kivity
2010-04-19 10:51 ` Peter Zijlstra
2010-04-19 10:54 ` Avi Kivity
2010-04-19 18:35 ` Zachary Amsden
2010-04-20 9:39 ` Avi Kivity
2010-04-21 0:05 ` Zachary Amsden
2010-04-21 8:08 ` Avi Kivity
2010-04-19 10:49 ` Peter Zijlstra
2010-04-19 10:53 ` Avi Kivity
2010-04-19 10:59 ` Peter Zijlstra
2010-04-19 11:35 ` Avi Kivity
2010-10-25 23:30 ` Jeremy Fitzhardinge
2010-10-26 8:14 ` Avi Kivity
2010-10-26 10:49 ` Glauber Costa
2010-10-26 17:04 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1271356648-5108-3-git-send-email-glommer@redhat.com \
--to=glommer@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®