From: Joe Perches <joe@perches.com>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: is there any chance of cleaning up the "inline" chaos?
Date: Sun, 18 Apr 2010 13:41:25 -0700 [thread overview]
Message-ID: <1271623285.1730.56.camel@Joe-Laptop.home> (raw)
In-Reply-To: <alpine.LFD.2.00.1004181605220.4775@localhost>
On Sun, 2010-04-18 at 16:06 -0400, Robert P. J. Day wrote:
> i mean, how many different definitions of inline are necessary?
>
> #if !defined(CONFIG_ARCH_SUPPORTS_OPTIMIZED_INLINING) || \
> !defined(CONFIG_OPTIMIZE_INLINING) || (__GNUC__ < 4)
> # define inline inline __attribute__((always_inline))
> # define __inline__ __inline__ __attribute__((always_inline))
> # define __inline __inline __attribute__((always_inline))
> #endif
Heave to, have at it.
$ git grep -w "inline" * | wc -l
35526
$ git grep -w "__inline__" * | wc -l
872
$ git grep -w "__inline" * | wc -l
17
It looks like __inline is almost exclusively in staging
and should be easy to fix/change
__inline__ is spread around all over the place
$ git grep -wl __inline__ * | wc -l
265
It could be converted over time or in a single sweep
like the recent slab changes.
prev parent reply other threads:[~2010-04-18 20:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-18 20:06 Robert P. J. Day
2010-04-18 20:41 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1271623285.1730.56.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®