From: Joe Perches <joe@perches.com>
To: Mikal Sande <mikal.sande@gmail.com>
Cc: andrew@lunn.ch, lindner_marek@yahoo.de, gregkh@suse.de,
siwu@hrz.tu-chemnitz.de, sdietrich@novell.com,
sven.eckelmann@gmx.de, linus.luessing@web.de,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: batman-adv: fix checkpath.pl issues
Date: Tue, 20 Apr 2010 18:06:28 -0700 [thread overview]
Message-ID: <1271811988.1730.244.camel@Joe-Laptop.home> (raw)
In-Reply-To: <1271810978.14405.14.camel@pondus>
On Wed, 2010-04-21 at 02:49 +0200, Mikal Sande wrote:
> @@ -212,7 +212,9 @@ ssize_t bat_device_write(struct file *file, const char __user *buff,
> unsigned long flags;
>
> if (len < sizeof(struct icmp_packet)) {
> - bat_dbg(DBG_BATMAN, "batman-adv:Error - can't send packet from char device: invalid packet size\n");
> + bat_dbg(DBG_BATMAN, "batman-adv:" +
> + "Error - can't send packet from char device: " +
> + "invalid packet size\n");
C doesn't use + for string concatenation.
Please compile test your changes before submitting them.
next prev parent reply other threads:[~2010-04-21 1:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-21 0:49 Mikal Sande
2010-04-21 1:06 ` Joe Perches [this message]
2010-04-21 6:32 ` Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1271811988.1730.244.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=andrew@lunn.ch \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=lindner_marek@yahoo.de \
--cc=linus.luessing@web.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mikal.sande@gmail.com \
--cc=sdietrich@novell.com \
--cc=siwu@hrz.tu-chemnitz.de \
--cc=sven.eckelmann@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®