mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: Gustavo Silva <silvagustavosilva@gmail.com>,
	gregkh@suse.de, abbotti@mev.co.uk, devel@driverdev.osuosl.org,
	fmhess@users.sourceforge.net, linux-kernel@vger.kernel.org,
	silvagustavo@users.sourceforge.net
Subject: Re: [PATCH] Staging: Comedi: Drivers: Fix coding style issues in dt2801.c
Date: Wed, 21 Apr 2010 21:36:11 -0700	[thread overview]
Message-ID: <1271910971.1730.637.camel@Joe-Laptop.home> (raw)
In-Reply-To: <20100422041338.GE24384@pengutronix.de>

On Thu, 2010-04-22 at 06:13 +0200, Wolfram Sang wrote:
> What about dev_* in case there are more than one of those devices?

or netdev_<level>

> Also, KERN_INFO doesn't look right, KERN_WARN?

KERN_WARNING.  Maybe kernel.h should add:
#define pr_warn pr_warning 

so there would be symmetry between levels of
pr_<level>, dev_<level>, netdev_<level>, and netif_<level>



  reply	other threads:[~2010-04-22  4:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-22  3:46 Gustavo Silva
2010-04-22  4:00 ` Joe Perches
2010-04-22  4:13   ` Wolfram Sang
2010-04-22  4:36     ` Joe Perches [this message]
2010-04-22  6:31       ` Wolfram Sang
2010-04-22  4:23   ` Gustavo Silva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1271910971.1730.637.camel@Joe-Laptop.home \
    --to=joe@perches.com \
    --cc=abbotti@mev.co.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=fmhess@users.sourceforge.net \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=silvagustavo@users.sourceforge.net \
    --cc=silvagustavosilva@gmail.com \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®