Re: [PATCH] Staging: comedi: fixed coding style issues in drivers.c

[Joe Perches <joe@perches.com>]

On Sun, 2010-04-25 at 09:58 -0400, zr.public@gmail.com wrote:
> From: Zachary_r <zr.public@gmail.com>
> @@ -123,8 +123,8 @@ int comedi_device_attach(struct comedi_device *dev, struct comedi_devconfig *it)
>  
>  	for (driv = comedi_drivers; driv; driv = driv->next) {
>  		if (!try_module_get(driv->module)) {
> -			printk
> -			    ("comedi: failed to increment module count, skipping\n");
> +			printk(KERN_INFO "comedi: failed to increment\
> +			module count, skipping\n");

Using line continuations like this is incorrect.
There are many uses like this in your proposed patch.

It adds the initial whitespace on the continued line
to the string constant.

Except for macro definitions, linux doesn't generally
use line continuations.

There's no attempt to keep line numbers consistent
across multiple versions.

cheers, Joe