mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Glauber Costa <glommer@redhat.com>
To: kvm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, avi@redhat.com
Subject: [PATCH 6/6] don't compute pvclock adjustments if we trust the tsc
Date: Mon, 26 Apr 2010 13:46:28 -0400	[thread overview]
Message-ID: <1272303988-21929-7-git-send-email-glommer@redhat.com> (raw)
In-Reply-To: <1272303988-21929-6-git-send-email-glommer@redhat.com>

If the HV told us we can fully trust the TSC, skip any
correction

Signed-off-by: Glauber Costa <glommer@redhat.com>
---
 arch/x86/include/asm/kvm_para.h    |    5 +++++
 arch/x86/include/asm/pvclock-abi.h |    1 +
 arch/x86/kernel/kvmclock.c         |    3 +++
 arch/x86/kernel/pvclock.c          |    4 ++++
 4 files changed, 13 insertions(+), 0 deletions(-)

diff --git a/arch/x86/include/asm/kvm_para.h b/arch/x86/include/asm/kvm_para.h
index f019f8c..615ebb1 100644
--- a/arch/x86/include/asm/kvm_para.h
+++ b/arch/x86/include/asm/kvm_para.h
@@ -21,6 +21,11 @@
  */
 #define KVM_FEATURE_CLOCKSOURCE2        3
 
+/* The last 8 bits are used to indicate how to interpret the flags field
+ * in pvclock structure. If no bits are set, all flags are ignored.
+ */
+#define KVM_FEATURE_CLOCKSOURCE_STABLE_TSC	0xf8
+
 #define MSR_KVM_WALL_CLOCK  0x11
 #define MSR_KVM_SYSTEM_TIME 0x12
 
diff --git a/arch/x86/include/asm/pvclock-abi.h b/arch/x86/include/asm/pvclock-abi.h
index ec5c41a..b123bd7 100644
--- a/arch/x86/include/asm/pvclock-abi.h
+++ b/arch/x86/include/asm/pvclock-abi.h
@@ -39,5 +39,6 @@ struct pvclock_wall_clock {
 	u32   nsec;
 } __attribute__((__packed__));
 
+#define PVCLOCK_STABLE_TSC	(1 << 0)
 #endif /* __ASSEMBLY__ */
 #endif /* _ASM_X86_PVCLOCK_ABI_H */
diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c
index f2f6aee..aca2d3c 100644
--- a/arch/x86/kernel/kvmclock.c
+++ b/arch/x86/kernel/kvmclock.c
@@ -218,4 +218,7 @@ void __init kvmclock_init(void)
 	clocksource_register(&kvm_clock);
 	pv_info.paravirt_enabled = 1;
 	pv_info.name = "KVM";
+
+	if (kvm_para_has_feature(KVM_FEATURE_CLOCKSOURCE_STABLE_TSC))
+		pvclock_valid_flags(PVCLOCK_STABLE_TSC);
 }
diff --git a/arch/x86/kernel/pvclock.c b/arch/x86/kernel/pvclock.c
index 6cf6dec..43ae8d5 100644
--- a/arch/x86/kernel/pvclock.c
+++ b/arch/x86/kernel/pvclock.c
@@ -135,6 +135,10 @@ cycle_t pvclock_clocksource_read(struct pvclock_vcpu_time_info *src)
 		barrier();
 	} while (version != src->version);
 
+	if ((valid_flags & PVCLOCK_STABLE_TSC) &&
+		(shadow->flags & PVCLOCK_STABLE_TSC))
+		return ret;
+
 	/*
 	 * Assumption here is that last_value, a global accumulator, always goes
 	 * forward. If we are less than that, we should not be much smaller.
-- 
1.6.2.2


  reply	other threads:[~2010-04-26 17:50 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-26 17:46 [PATCH 0/6] pvclock fixes Glauber Costa
2010-04-26 17:46 ` [PATCH 1/6] Enable pvclock flags in vcpu_time_info structure Glauber Costa
2010-04-26 17:46   ` [PATCH 2/6] Add a global synchronization point for pvclock Glauber Costa
2010-04-26 17:46     ` [PATCH 3/6] change msr numbers for kvmclock Glauber Costa
2010-04-26 17:46       ` [PATCH 4/6] export new cpuid KVM_CAP Glauber Costa
2010-04-26 17:46         ` [PATCH 5/6] Try using new kvm clock msrs Glauber Costa
2010-04-26 17:46           ` Glauber Costa [this message]
2010-04-27 13:40             ` [PATCH 6/6] don't compute pvclock adjustments if we trust the tsc Marcelo Tosatti
2010-04-27 15:11               ` Glauber Costa
2010-04-27 18:03               ` Avi Kivity
2010-04-27 18:57                 ` Glauber Costa
2010-04-27 13:35           ` [PATCH 5/6] Try using new kvm clock msrs Marcelo Tosatti
2010-04-27 13:30         ` [PATCH 4/6] export new cpuid KVM_CAP Marcelo Tosatti
2010-04-27 15:09           ` Glauber Costa
2010-04-27 16:55           ` Glauber Costa
2010-04-27 18:12         ` Avi Kivity
2010-04-27 19:09           ` Glauber Costa
2010-04-27 19:20             ` Avi Kivity
2010-04-27 13:28     ` [PATCH 2/6] Add a global synchronization point for pvclock Marcelo Tosatti
2010-04-27 18:00       ` Jeremy Fitzhardinge
2010-04-26 18:11   ` [PATCH 1/6] Enable pvclock flags in vcpu_time_info structure Jeremy Fitzhardinge
2010-04-26 18:45     ` Glauber Costa
2010-04-27 18:07   ` Avi Kivity
2010-04-27 19:09     ` Glauber Costa
2010-04-27  2:21 ` [PATCH 0/6] pvclock fixes Zachary Amsden

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1272303988-21929-7-git-send-email-glommer@redhat.com \
    --to=glommer@redhat.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®