mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
To: Valdis.Kletnieks@vt.edu
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: mmotm 2010-04-22-16-38 uploaded
Date: Mon, 26 Apr 2010 17:41:19 -0400	[thread overview]
Message-ID: <1272318079.16810.44.camel@useless.americas.hpqcorp.net> (raw)
In-Reply-To: <31157.1271987879@localhost>

On Thu, 2010-04-22 at 21:57 -0400, Valdis.Kletnieks@vt.edu wrote:
> On Thu, 22 Apr 2010 16:38:55 PDT, akpm@linux-foundation.org said:
> > The mm-of-the-moment snapshot 2010-04-22-16-38 has been uploaded to
> > 
> >    http://userweb.kernel.org/~akpm/mmotm/
> 
> Found this in numa-introduce-numa_mem_id-effective-local-memory-node-id.patch:
> 
> +#ifndef cpu_to_mem
> +#define cpu_to_mem(cpu)                (void)(cpu),0)
> +#endif
> 
> The resulting paren mismatch causes an error cascade in 2 other patches:
> 
> numa-in-kernel-profiling-use-cpu_to_mem-for-per-cpu-allocations.patch
> 
> causes build errors:

Thanks, Valdis.  I encountered this error and thought I fixed it before
submitting the series.  Apparently I submitted a stale patch.

Attached patch fixes the problem.

Lee


========================================
Fix to numa-introduce-numa_mem_id-effective-local-memory-node-id.patch
in mmotm 100422-1638

Add missing parenthesis to !NUMA stub cpu_to_mem() definition

Signed-off-by: Lee Schermerhorn <lee.schermerhorn@hp.com>

 include/asm-generic/topology.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.34-rc5-mmotm-100422-1638/include/asm-generic/topology.h
===================================================================
--- linux-2.6.34-rc5-mmotm-100422-1638.orig/include/asm-generic/topology.h
+++ linux-2.6.34-rc5-mmotm-100422-1638/include/asm-generic/topology.h
@@ -35,7 +35,7 @@
 #define cpu_to_node(cpu)	((void)(cpu),0)
 #endif
 #ifndef cpu_to_mem
-#define cpu_to_mem(cpu)		(void)(cpu),0)
+#define cpu_to_mem(cpu)		((void)(cpu),0)
 #endif
 #ifndef parent_node
 #define parent_node(node)	((void)(node),0)




      reply	other threads:[~2010-04-26 21:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-22 23:38 akpm
2010-04-23  0:46 ` KAMEZAWA Hiroyuki
2010-04-23  1:40   ` Valdis.Kletnieks
2010-04-23  1:57 ` Valdis.Kletnieks
2010-04-26 21:41   ` Lee Schermerhorn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1272318079.16810.44.camel@useless.americas.hpqcorp.net \
    --to=lee.schermerhorn@hp.com \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®