From: Thomas Renninger <trenn@suse.de>
To: x86@kernel.org
Cc: linux-trace-users@vger.kernel.org,
linux-perf-users@vger.kernel.org, robert.schoene@tu-dresden.de,
cpufreq@vger.kernel.org, linux-kernel@vger.kernel.org,
davej@redhat.com, arjan@infradead.org,
Thomas Renninger <trenn@suse.de>,
venki@google.com
Subject: [PATCH 1/2] acpi-cpufreq: Fix CPU_ANY CPUFREQ_{PRE,POST}CHANGE notification
Date: Tue, 27 Apr 2010 16:57:41 +0200 [thread overview]
Message-ID: <1272380262-23671-2-git-send-email-trenn@suse.de> (raw)
In-Reply-To: <1272380262-23671-1-git-send-email-trenn@suse.de>
This has been found be review.
Currently PRE/POSTCHANGE events seem to only be thrown for one core
if the BIOS tells us to run in CPU_ANY mode (switching one/any
of the depending cores is enough).
Signed-off-by: Thomas Renninger <trenn@suse.de>
CC: venki@google.com
CC: davej@redhat.com
CC: linux-kernel@vger.kernel.org
CC: cpufreq@vger.kernel.org
CC: linux-perf-users@vger.kernel.org
CC: linux-trace-users@vger.kernel.org
CC: x86@kernel.org
CC: robert.schoene@tu-dresden.de
---
arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c b/arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c
index 4591680..c6de3a9 100644
--- a/arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c
+++ b/arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c
@@ -391,7 +391,7 @@ static int acpi_cpufreq_target(struct cpufreq_policy *policy,
freqs.old = perf->states[perf->state].core_frequency * 1000;
freqs.new = data->freq_table[next_state].frequency;
- for_each_cpu(i, cmd.mask) {
+ for_each_cpu(i, policy->cpus) {
freqs.cpu = i;
cpufreq_notify_transition(&freqs, CPUFREQ_PRECHANGE);
}
@@ -407,7 +407,7 @@ static int acpi_cpufreq_target(struct cpufreq_policy *policy,
}
}
- for_each_cpu(i, cmd.mask) {
+ for_each_cpu(i, policy->cpus) {
freqs.cpu = i;
cpufreq_notify_transition(&freqs, CPUFREQ_POSTCHANGE);
}
--
1.6.3
next prev parent reply other threads:[~2010-04-27 14:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-27 14:57 Implement trace_power_frequency for all cpufreq drivers Thomas Renninger
2010-04-27 14:57 ` Thomas Renninger [this message]
2010-04-27 17:08 ` [PATCH 1/2] acpi-cpufreq: Fix CPU_ANY CPUFREQ_{PRE,POST}CHANGE notification Venkatesh Pallipadi
2010-04-27 14:57 ` [PATCH 2/2] x86 cpufreq: Make trace_power_frequency cpufreq driver independent Thomas Renninger
2010-04-30 9:08 ` Ingo Molnar
2010-04-30 10:00 ` Thomas Renninger
-- strict thread matches above, loose matches on Subject: below --
2010-04-20 11:17 [PATCH 1/2] acpi-cpufreq: Fix CPU_ANY CPUFREQ_{PRE,POST}CHANGE notification Thomas Renninger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1272380262-23671-2-git-send-email-trenn@suse.de \
--to=trenn@suse.de \
--cc=arjan@infradead.org \
--cc=cpufreq@vger.kernel.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-trace-users@vger.kernel.org \
--cc=robert.schoene@tu-dresden.de \
--cc=venki@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome