mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Henrik Kretzschmar <henne@nachtwindheim.de>
To: linux-fbdev@vger.kernel.org
Cc: ralf@linux-mips.org, arnaud.patard@rtp-net.org,
	jayakumar.lkml@gmail.com, gregkh@suse.de, yuasa@linux-mips.org,
	lethal@linux-sh.org, akpm@linux-foundation.org,
	adobriyan@gmail.com, support@simtec.co.uk, ben@simtec.co.uk,
	linux@simtec.co.uk, jkosina@suse.cz, pjones@redhat.com,
	linux-kernel@vger.kernel.org,
	Henrik Kretzschmar <henne@nachtwindheim.de>
Subject: [PATCH 2/4] hitfb: correct sections
Date: Wed, 28 Apr 2010 12:25:03 +0200	[thread overview]
Message-ID: <1272450305-7284-2-git-send-email-henne@nachtwindheim.de> (raw)
In-Reply-To: <1272450305-7284-1-git-send-email-henne@nachtwindheim.de>

Since the drivers probe call was changed from .init.text
to .devinit.text in commit c2e13037e6794bd0d9de3f9ecabf5615f15c160b
the fb_fix_screeninfo and fb_var_screeninfo structures must be
changed from .init.data to .devinit.data, too.

Also the drivers remove routine should be moved from
.exit.text to .devexit.text

Signed-off-by: Henrik Kretzschmar <henne@nachtwindheim.de>
---
It would be nice if someone with a SH gcc could test this patch and
give me some feedback if it works the way it should, since atm I'm lacking
a crosscompiler setup.
---
 drivers/video/hitfb.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/video/hitfb.c b/drivers/video/hitfb.c
index 393f3f3..cfb8d64 100644
--- a/drivers/video/hitfb.c
+++ b/drivers/video/hitfb.c
@@ -30,14 +30,14 @@
 
 #define	WIDTH 640
 
-static struct fb_var_screeninfo hitfb_var __initdata = {
+static struct fb_var_screeninfo hitfb_var __devinitdata = {
 	.activate	= FB_ACTIVATE_NOW,
 	.height		= -1,
 	.width		= -1,
 	.vmode		= FB_VMODE_NONINTERLACED,
 };
 
-static struct fb_fix_screeninfo hitfb_fix __initdata = {
+static struct fb_fix_screeninfo hitfb_fix __devinitdata = {
 	.id		= "Hitachi HD64461",
 	.type		= FB_TYPE_PACKED_PIXELS,
 	.accel		= FB_ACCEL_NONE,
@@ -417,7 +417,7 @@ err_fb:
 	return ret;
 }
 
-static int __exit hitfb_remove(struct platform_device *dev)
+static int __devexit hitfb_remove(struct platform_device *dev)
 {
 	struct fb_info *info = platform_get_drvdata(dev);
 
@@ -462,7 +462,7 @@ static const struct dev_pm_ops hitfb_dev_pm_ops = {
 
 static struct platform_driver hitfb_driver = {
 	.probe		= hitfb_probe,
-	.remove		= __exit_p(hitfb_remove),
+	.remove		= __devexit_p(hitfb_remove),
 	.driver		= {
 		.name	= "hitfb",
 		.owner	= THIS_MODULE,
-- 
1.7.0


  reply	other threads:[~2010-04-28 10:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-28 10:25 [PATCH 1/4] cocbalt_lcdfb: " Henrik Kretzschmar
2010-04-28 10:25 ` Henrik Kretzschmar [this message]
2010-04-28 10:25 ` [PATCH 3/4] s3c2410fb: " Henrik Kretzschmar
2010-04-28 21:16   ` Arnaud Patard
2010-04-28 10:25 ` [PATCH 4/4] sgivwfb: " Henrik Kretzschmar
2010-04-28 14:32 ` [PATCH 1/4] cocbalt_lcdfb: " Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1272450305-7284-2-git-send-email-henne@nachtwindheim.de \
    --to=henne@nachtwindheim.de \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnaud.patard@rtp-net.org \
    --cc=ben@simtec.co.uk \
    --cc=gregkh@suse.de \
    --cc=jayakumar.lkml@gmail.com \
    --cc=jkosina@suse.cz \
    --cc=lethal@linux-sh.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@simtec.co.uk \
    --cc=pjones@redhat.com \
    --cc=ralf@linux-mips.org \
    --cc=support@simtec.co.uk \
    --cc=yuasa@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®