From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756647Ab0D1TEw (ORCPT ); Wed, 28 Apr 2010 15:04:52 -0400 Received: from mail.perches.com ([173.55.12.10]:1794 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754483Ab0D1TEv (ORCPT ); Wed, 28 Apr 2010 15:04:51 -0400 Subject: Re: [PATCH 09/13] drivers/staging/rtl8192su: Hoist assign from if From: Joe Perches To: Greg KH Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, Greg Kroah-Hartman In-Reply-To: <20100428182710.GD8509@kroah.com> References: <20100428182710.GD8509@kroah.com> Content-Type: text/plain; charset="UTF-8" Date: Wed, 28 Apr 2010 12:04:49 -0700 Message-ID: <1272481489.7831.24.camel@Joe-Laptop.home> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2010-04-28 at 11:27 -0700, Greg KH wrote: > On Wed, Mar 24, 2010 at 10:17:03PM -0700, Joe Perches wrote: > > --- a/drivers/staging/rtl8192su/ieee80211/ieee80211_softmac.c > > +++ b/drivers/staging/rtl8192su/ieee80211/ieee80211_softmac.c > > @@ -1690,7 +1690,8 @@ ieee80211_rx_auth_rq(struct ieee80211_device *ieee, struct sk_buff *skb) > > //IEEE80211DMESG("Rx probe"); > > ieee->softmac_stats.rx_auth_rq++; > > > > - if ((status = auth_rq_parse(skb, dest))!= -1){ > > + status = auth_rq_parse(skb, dest); > > + if (status!= -1) { > > And again. Did you do this with some tool and not by hand? [] > Did you not run your patch through checkpatch after creating it and > before sending it to me? >>From the original 0/13 introduction: http://lkml.org/lkml/2010/3/25/6 Used scripts/cvt_kernel.style.pl: --convert-hoist_assigns_from_if and verified visually. checkpatch errors ignored The script itself is: http://lkml.org/lkml/2010/3/24/447 >>From an earlier Greg KH email: > Careful that you don't add new coding style issues to a staging driver Avoiding checkpatch errors and avoiding new coding style issues are frequently conflicting goals. I try not to add "new" issues. and I generally leave the old ones alone. I don't use checkpatch as a guide for what to fix or as an inhibitor on what style patch to send.