From: tom.leiming@gmail.com
To: mingo@elte.hu
Cc: linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl,
Ming Lei <tom.leiming@gmail.com>
Subject: [PATCH 2/2] lockdep: allow user to disable CONFIG_TRACE_IRQFLAGS
Date: Wed, 5 May 2010 00:02:24 +0800 [thread overview]
Message-ID: <1272988944-2448-1-git-send-email-tom.leiming@gmail.com> (raw)
From: Ming Lei <tom.leiming@gmail.com>
There is still the lost irq-on tracing issue on ARM,
(see http://marc.info/?l=linux-arm-kernel&m=126047420005553&w=2)
which may disable lockdep after kernel boot, seems no
good solution for the issue up to now.
The patch exports the config option of CONFIG_TRACE_IRQFLAGS
and allows user to disable it for support of checking circular
dead lock only if irq flags tracing can't work correctly always.
Signed-off-by: Ming Lei <tom.leiming@gmail.com>
---
lib/Kconfig.debug | 3 +++
lib/locking-selftest.c | 2 ++
2 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 935248b..448f18f 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -550,11 +550,14 @@ config DEBUG_LOCKDEP
of more runtime overhead.
config TRACE_IRQFLAGS
+ bool "Lock prove: IRQ flags tracing"
depends on DEBUG_KERNEL
bool
default y
depends on TRACE_IRQFLAGS_SUPPORT
depends on PROVE_LOCKING
+ help
+ If you say Y here, IRQ flags will be traced to prove locking.
config DEBUG_SPINLOCK_SLEEP
bool "Spinlock debugging: sleep-inside-spinlock checking"
diff --git a/lib/locking-selftest.c b/lib/locking-selftest.c
index 619313e..d9e5bfe 100644
--- a/lib/locking-selftest.c
+++ b/lib/locking-selftest.c
@@ -1176,6 +1176,7 @@ void locking_selftest(void)
printk(" --------------------------------------------------------------------------\n");
+#ifdef CONFIG_TRACE_IRQFLAGS
/*
* irq-context testcases:
*/
@@ -1188,6 +1189,7 @@ void locking_selftest(void)
DO_TESTCASE_6x2("irq read-recursion", irq_read_recursion);
// DO_TESTCASE_6x2B("irq read-recursion #2", irq_read_recursion2);
+#endif
if (unexpected_testcase_failures) {
printk("-----------------------------------------------------------------\n");
--
1.6.2.5
next reply other threads:[~2010-05-04 16:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-04 16:02 tom.leiming [this message]
2010-05-04 16:06 ` Ming Lei
2010-05-04 16:26 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1272988944-2448-1-git-send-email-tom.leiming@gmail.com \
--to=tom.leiming@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®