From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933296Ab0EDScO (ORCPT ); Tue, 4 May 2010 14:32:14 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.125]:37435 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932269Ab0EDScN (ORCPT ); Tue, 4 May 2010 14:32:13 -0400 X-Authority-Analysis: v=1.1 cv=OMZqYO3L41gFG4eI735GctFZkIqa2t9YKv4cWfI71LE= c=1 sm=0 a=Ha1kYoaTZc4A:10 a=7U3hwN5JcxgA:10 a=Q9fys5e9bTEA:10 a=gMqfjgEr1zLu/65IO0LwxA==:17 a=meVymXHHAAAA:8 a=92wXTOoxxlBlMh_gTWUA:9 a=b2v7DOiTuawWeoiR3VYA:7 a=LsziBkYcsyfi6KROkygR2W4FpCAA:4 a=PUjeQqilurYA:10 a=jeBq3FmKZ4MA:10 a=gMqfjgEr1zLu/65IO0LwxA==:117 X-Cloudmark-Score: 0 X-Originating-IP: 74.67.89.75 Subject: Re: [PATCH 04/12] perf: add @rq to perf_event_task_sched_out() From: Steven Rostedt Reply-To: rostedt@goodmis.org To: Peter Zijlstra Cc: Tejun Heo , mingo@elte.hu, efault@gmx.de, avi@redhat.com, paulus@samba.org, acme@redhat.com, linux-kernel@vger.kernel.org In-Reply-To: <1272997616.1642.207.camel@laptop> References: <1272976724-14312-1-git-send-email-tj@kernel.org> <1272976724-14312-5-git-send-email-tj@kernel.org> <1272993090.1642.184.camel@laptop> <4BE057EB.80604@kernel.org> <1272997363.9739.232.camel@gandalf.stny.rr.com> <1272997616.1642.207.camel@laptop> Content-Type: text/plain; charset="ISO-8859-15" Organization: Kihon Technologies Inc. Date: Tue, 04 May 2010 14:32:10 -0400 Message-ID: <1272997930.9739.233.camel@gandalf.stny.rr.com> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2010-05-04 at 20:26 +0200, Peter Zijlstra wrote: > On Tue, 2010-05-04 at 14:22 -0400, Steven Rostedt wrote: > > On Tue, 2010-05-04 at 19:22 +0200, Tejun Heo wrote: > > > Hello, > > > > > > On 05/04/2010 07:11 PM, Peter Zijlstra wrote: > > > > On Tue, 2010-05-04 at 14:38 +0200, Tejun Heo wrote: > > > >> Add @rq to perf_event_task_sched_out() so that its argument matches > > > >> those of trace_sched_switch(). This will help unifying notifiers in > > > >> sched. > > > > > > > > The alternative is dropping rq from the trace events, its not like > > > > anybody outside sched.o can do anything sensible with it anyway. > > > > > > The comment in include/trace/events/sched.h says... > > > > > > * (NOTE: the 'rq' argument is not used by generic trace events, > > > * but used by the latency tracer plugin. ) > > > > > > So, I left it there. It would be great if all those @rq params can be > > > removed tho. The latency tracer thing needs it, right? > > > > I believe the rq was used by the original latency tracer code that was > > in the -rt patch set before ftrace. It is most likely there for > > historical purposes. I guess it would be fine to just remove it. > > I'm building the below, so far so good... ;-) > > --- > include/trace/events/sched.h | 32 ++++++++++---------------------- > kernel/sched.c | 8 ++++---- > kernel/trace/trace_sched_wakeup.c | 5 ++--- > 3 files changed, 16 insertions(+), 29 deletions(-) > > diff --git a/include/trace/events/sched.h b/include/trace/events/sched.h > index cfceb0b..4f733ec 100644 > --- a/include/trace/events/sched.h > +++ b/include/trace/events/sched.h > @@ -51,15 +51,12 @@ TRACE_EVENT(sched_kthread_stop_ret, > > /* > * Tracepoint for waiting on task to unschedule: > - * > - * (NOTE: the 'rq' argument is not used by generic trace events, > - * but used by the latency tracer plugin. ) > */ > TRACE_EVENT(sched_wait_task, > > - TP_PROTO(struct rq *rq, struct task_struct *p), > + TP_PROTO(struct task_struct *p), Acked-by: Steven Rostedt -- Steve