mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: How to write marker info in MMIO trace from kernel
Date: Tue, 04 May 2010 18:58:09 -0400	[thread overview]
Message-ID: <1273013889.22438.8.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <4BE09F42.9070909@lwfinger.net>

On Tue, 2010-05-04 at 17:27 -0500, Larry Finger wrote:

> Thanks for the info. One other question - when I write only mmiotrace to
> the current_tracer, the trace_printk() stuff does not end up in the
> buffer. I can get it by using the "sysprof" tracer, but that has a lot
> of stuff I do not want. Did I miss some configuration? My list of
> available tracers is "blk kmemtrace mmiotrace wakeup_rt wakeup function
> sysprof sched_switch nop".

Ug, that's because the mmiotrace handles its own prints and ignores
anything it does not know about. Here, try this patch:

-- Steve

diff --git a/kernel/trace/trace_mmiotrace.c b/kernel/trace/trace_mmiotrace.c
index 017fa37..8652f28 100644
--- a/kernel/trace/trace_mmiotrace.c
+++ b/kernel/trace/trace_mmiotrace.c
@@ -282,7 +282,7 @@ static enum print_line_t mmio_print_line(struct trace_iterator *iter)
 	case TRACE_PRINT:
 		return mmio_print_mark(iter);
 	default:
-		return TRACE_TYPE_HANDLED; /* ignore unknown entries */
+		return TRACE_TYPE_UNHANDLED;
 	}
 }
 



  reply	other threads:[~2010-05-04 22:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-04 18:36 Larry Finger
2010-05-04 18:42 ` Steven Rostedt
2010-05-04 22:27   ` Larry Finger
2010-05-04 22:58     ` Steven Rostedt [this message]
2010-05-05  0:33       ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1273013889.22438.8.camel@gandalf.stny.rr.com \
    --to=rostedt@goodmis.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®