From: Nitin Gupta <ngupta@vflare.org>
To: Greg KH <greg@kroah.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Hugh Dickins <hugh.dickins@tiscali.co.uk>, Cyp <cyp561@gmail.com>,
Minchan Kim <minchan.kim@gmail.com>,
Al Viro <viro@ZenIV.linux.org.uk>,
Christoph Hellwig <hch@infradead.org>,
Jens Axboe <jens.axboe@oracle.com>,
Andi Kleen <andi@firstfloor.org>,
Andrew Morton <akpm@linux-foundation.org>,
driverdev <devel@driverdev.osuosl.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH 1/3] Add flag to identify block swap devices
Date: Fri, 7 May 2010 12:55:05 +0530 [thread overview]
Message-ID: <1273217107-2023-2-git-send-email-ngupta@vflare.org> (raw)
In-Reply-To: <1273217107-2023-1-git-send-email-ngupta@vflare.org>
Added SWP_BLKDEV flag to distinguish block and regular file backed
swap devices. We could also check if a swap is entire block device,
rather than a file, by:
S_ISBLK(swap_info_struct->swap_file->f_mapping->host->i_mode)
but, I think, simply checking this flag is more convenient.
Signed-off-by: Nitin Gupta <ngupta@vflare.org>
---
include/linux/swap.h | 1 +
mm/swapfile.c | 1 +
2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/include/linux/swap.h b/include/linux/swap.h
index 1f59d93..ec2b7a4 100644
--- a/include/linux/swap.h
+++ b/include/linux/swap.h
@@ -146,6 +146,7 @@ enum {
SWP_DISCARDING = (1 << 3), /* now discarding a free cluster */
SWP_SOLIDSTATE = (1 << 4), /* blkdev seeks are cheap */
SWP_CONTINUED = (1 << 5), /* swap_map has count continuation */
+ SWP_BLKDEV = (1 << 6), /* its a block device */
/* add others here before... */
SWP_SCANNING = (1 << 8), /* refcount in scan_swap_map */
};
diff --git a/mm/swapfile.c b/mm/swapfile.c
index 6cd0a8f..ecb069e 100644
--- a/mm/swapfile.c
+++ b/mm/swapfile.c
@@ -1884,6 +1884,7 @@ SYSCALL_DEFINE2(swapon, const char __user *, specialfile, int, swap_flags)
if (error < 0)
goto bad_swap;
p->bdev = bdev;
+ p->flags |= SWP_BLKDEV;
} else if (S_ISREG(inode->i_mode)) {
p->bdev = inode->i_sb->s_bdev;
mutex_lock(&inode->i_mutex);
--
1.6.6.1
next prev parent reply other threads:[~2010-05-07 7:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 7:25 [PATCH 0/3] ramzswap: Eliminate stale data from compressed memory (v2) Nitin Gupta
2010-05-07 7:25 ` Nitin Gupta [this message]
2010-05-07 8:03 ` [PATCH 1/3] Add flag to identify block swap devices jassi brar
2010-05-07 8:16 ` Nitin Gupta
2010-05-07 8:56 ` jassi brar
2010-05-07 9:24 ` Pekka Enberg
2010-05-07 9:32 ` Nigel Cunningham
2010-05-07 7:25 ` [PATCH 2/3] Add swap slot free callback to block_device_operations Nitin Gupta
2010-05-07 9:22 ` Nigel Cunningham
2010-05-07 9:48 ` Nitin Gupta
2010-05-07 10:40 ` Nigel Cunningham
2010-05-07 7:25 ` [PATCH 3/3] ramzswap: Handler for swap slot free callback Nitin Gupta
2010-05-07 7:44 ` [PATCH 0/3] ramzswap: Eliminate stale data from compressed memory (v2) Pekka Enberg
2010-05-07 14:51 ` Linus Torvalds
2010-05-07 19:55 ` Andrew Morton
2010-05-08 4:05 ` Nitin Gupta
2010-05-08 6:29 ` Pekka Enberg
2010-05-08 6:54 ` Nitin Gupta
2010-05-08 7:05 ` Pekka Enberg
2010-05-08 6:57 ` Nitin Gupta
2010-05-08 7:26 ` Pekka Enberg
2010-05-08 7:32 ` Nitin Gupta
2010-05-17 5:32 [PATCH 0/3] ramzswap: Eliminate stale data from compressed memory (v2 resend) Nitin Gupta
2010-05-17 5:32 ` [PATCH 1/3] Add flag to identify block swap devices Nitin Gupta
2010-05-17 11:50 ` Minchan Kim
2010-05-17 19:35 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273217107-2023-2-git-send-email-ngupta@vflare.org \
--to=ngupta@vflare.org \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=cyp561@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=greg@kroah.com \
--cc=hch@infradead.org \
--cc=hugh.dickins@tiscali.co.uk \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan.kim@gmail.com \
--cc=penberg@cs.helsinki.fi \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®