From: Tom Zanussi <tzanussi@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@elte.hu, fweisbec@gmail.com, acme@ghostprotocols.net
Subject: [PATCH 6/9] perf/trace/scripting: don't show script start/stop messages by default
Date: Sun, 9 May 2010 23:46:57 -0500 [thread overview]
Message-ID: <1273466820-9330-7-git-send-email-tzanussi@gmail.com> (raw)
In-Reply-To: <1273466820-9330-1-git-send-email-tzanussi@gmail.com>
Only print the script start/stop messages in verbose mode - users
normally don't care and it just clutters up the output.
Signed-off-by: Tom Zanussi <tzanussi@gmail.com>
---
tools/perf/builtin-trace.c | 3 +++
.../perf/util/scripting-engines/trace-event-perl.c | 3 ---
.../util/scripting-engines/trace-event-python.c | 4 ----
3 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index 9c483e9..cd9cffc 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -53,6 +53,8 @@ static void setup_scripting(void)
static int cleanup_scripting(void)
{
+ pr_debug("\nperf trace script stopped\n");
+
return scripting_ops->stop_script();
}
@@ -703,6 +705,7 @@ int cmd_trace(int argc, const char **argv, const char *prefix __used)
err = scripting_ops->start_script(script_name, argc, argv);
if (err)
goto out;
+ pr_debug("perf trace started with script %s\n\n", script_name);
}
err = __cmd_trace(session);
diff --git a/tools/perf/util/scripting-engines/trace-event-perl.c b/tools/perf/util/scripting-engines/trace-event-perl.c
index 5376378..b059dc5 100644
--- a/tools/perf/util/scripting-engines/trace-event-perl.c
+++ b/tools/perf/util/scripting-engines/trace-event-perl.c
@@ -371,7 +371,6 @@ static int perl_start_script(const char *script, int argc, const char **argv)
run_start_sub();
free(command_line);
- fprintf(stderr, "perf trace started with Perl script %s\n\n", script);
return 0;
error:
perl_free(my_perl);
@@ -394,8 +393,6 @@ static int perl_stop_script(void)
perl_destruct(my_perl);
perl_free(my_perl);
- fprintf(stderr, "\nperf trace Perl script stopped\n");
-
return 0;
}
diff --git a/tools/perf/util/scripting-engines/trace-event-python.c b/tools/perf/util/scripting-engines/trace-event-python.c
index 6a72f14..81f39ca 100644
--- a/tools/perf/util/scripting-engines/trace-event-python.c
+++ b/tools/perf/util/scripting-engines/trace-event-python.c
@@ -374,8 +374,6 @@ static int python_start_script(const char *script, int argc, const char **argv)
}
free(command_line);
- fprintf(stderr, "perf trace started with Python script %s\n\n",
- script);
return err;
error:
@@ -407,8 +405,6 @@ out:
Py_XDECREF(main_module);
Py_Finalize();
- fprintf(stderr, "\nperf trace Python script stopped\n");
-
return err;
}
--
1.6.4.GIT
next prev parent reply other threads:[~2010-05-10 4:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-10 4:46 [PATCH 0/9] perf-trace/scripting: script fixes Tom Zanussi
2010-05-10 4:46 ` [PATCH 1/9] perf/trace/scripting: failed-syscalls script cleanup Tom Zanussi
2010-05-10 4:46 ` [PATCH 2/9] perf/trace/scripting: rw-by-pid " Tom Zanussi
2010-05-10 4:46 ` [PATCH 3/9] perf/trace/scripting: rwtop " Tom Zanussi
2010-05-10 4:46 ` [PATCH 4/9] perf/trace/scripting: wakeup-latency " Tom Zanussi
2010-05-10 4:46 ` [PATCH 5/9] perf/trace/scripting: workqueue-stats " Tom Zanussi
2010-05-10 4:46 ` Tom Zanussi [this message]
2010-05-10 4:46 ` [PATCH 7/9] perf/trace/scripting: failed-syscalls-by-pid " Tom Zanussi
2010-05-10 4:46 ` [PATCH 8/9] perf/trace/scripting: syscall-counts-by-pid " Tom Zanussi
2010-05-10 4:47 ` [PATCH 9/9] perf/trace/scripting: syscall-counts " Tom Zanussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273466820-9330-7-git-send-email-tzanussi@gmail.com \
--to=tzanussi@gmail.com \
--cc=acme@ghostprotocols.net \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®