From: Peter Zijlstra <peterz@infradead.org>
To: Lin Ming <ming.m.lin@intel.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Frederic Weisbecker <fweisbec@gmail.com>,
"eranian@gmail.com" <eranian@gmail.com>,
"Gary.Mohr@Bull.com" <Gary.Mohr@bull.com>,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
"arjan@linux.intel.com" <arjan@linux.intel.com>,
"Zhang, Yanmin" <yanmin_zhang@linux.intel.com>,
Paul Mackerras <paulus@samba.org>,
"David S. Miller" <davem@davemloft.net>,
Russell King <rmk+kernel@arm.linux.org.uk>,
Paul Mundt <lethal@linux-sh.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [RFC][PATCH 9/9] perf top: set perf_event_attr->pmu_id
Date: Mon, 10 May 2010 11:43:11 +0200 [thread overview]
Message-ID: <1273484591.5605.3337.camel@twins> (raw)
In-Reply-To: <1273483760.15998.63.camel@minggr.sh.intel.com>
On Mon, 2010-05-10 at 17:29 +0800, Lin Ming wrote:
> This is just a temporary patch to show the setting of
> perf_event_attr->pmu_id.
>
> Signed-off-by: Lin Ming <ming.m.lin@intel.com>
> ---
> tools/perf/builtin-top.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
> index ed9b5b6..f775393 100644
> --- a/tools/perf/builtin-top.c
> +++ b/tools/perf/builtin-top.c
> @@ -1213,6 +1213,11 @@ static void start_counter(int i, int counter)
>
> attr = attrs + counter;
>
> + /*
> + * TBD: in the future, may read /sys/devices/system/cpu/pmus/<pmu_id>
> + * to get the pmu id
> + */
> + attr.pmu_id = 0;
No, cpu PMUs must always be pmu_id 0.
prev parent reply other threads:[~2010-05-10 9:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-10 9:29 Lin Ming
2010-05-10 9:43 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273484591.5605.3337.camel@twins \
--to=peterz@infradead.org \
--cc=Gary.Mohr@bull.com \
--cc=arjan@linux.intel.com \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=eranian@gmail.com \
--cc=fweisbec@gmail.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome