From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org,
"Arnaldo Carvalho de Melo" <acme@redhat.com>,
"Frédéric Weisbecker" <fweisbec@gmail.com>,
"Mike Galbraith" <efault@gmx.de>,
"Paul Mackerras" <paulus@samba.org>,
"Peter Zijlstra" <a.p.zijlstra@chello.nl>,
"Tom Zanussi" <tzanussi@gmail.com>
Subject: [PATCH 3/4] perf session: create_kernel_maps should use ->host_machine
Date: Mon, 10 May 2010 13:32:20 -0300 [thread overview]
Message-ID: <1273509141-15696-4-git-send-email-acme@infradead.org> (raw)
In-Reply-To: <1273509141-15696-1-git-send-email-acme@infradead.org>
From: Arnaldo Carvalho de Melo <acme@redhat.com>
Using machines__create_kernel_maps(..., HOST_KERNEL_ID) it would create
another machine instance for the host machine, and since 1f626bc we have
it out of the machines rb_tree.
Fix it by using machine__create_kernel_maps(&self->host_machine)
directly.
Cc: Frédéric Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Tom Zanussi <tzanussi@gmail.com>
LKML-Reference: <new-submission>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/session.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
index c088d8f..4130036 100644
--- a/tools/perf/util/session.c
+++ b/tools/perf/util/session.c
@@ -69,11 +69,10 @@ void perf_session__update_sample_type(struct perf_session *self)
int perf_session__create_kernel_maps(struct perf_session *self)
{
- struct rb_root *machines = &self->machines;
- int ret = machines__create_kernel_maps(machines, HOST_KERNEL_ID);
+ int ret = machine__create_kernel_maps(&self->host_machine);
if (ret >= 0)
- ret = machines__create_guest_kernel_maps(machines);
+ ret = machines__create_guest_kernel_maps(&self->machines);
return ret;
}
--
1.6.2.5
next prev parent reply other threads:[~2010-05-10 16:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-10 16:32 [GIT PULL 0/4] perf improvements and fixes Arnaldo Carvalho de Melo
2010-05-10 16:32 ` [PATCH 1/4] perf newt: Use newtAddComponent() Arnaldo Carvalho de Melo
2010-05-10 16:32 ` [PATCH 2/4] perf callchains: Use zalloc to allocate objects Arnaldo Carvalho de Melo
2010-05-10 16:32 ` Arnaldo Carvalho de Melo [this message]
2010-05-10 16:32 ` [PATCH 4/4] perf hist: Introduce hists class and move lots of methods to it Arnaldo Carvalho de Melo
2010-05-10 16:59 ` [GIT PULL 0/4] perf improvements and fixes Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273509141-15696-4-git-send-email-acme@infradead.org \
--to=acme@infradead.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=efault@gmx.de \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®