From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org, "Tom Zanussi" <tzanussi@gmail.com>,
"Frédéric Weisbecker" <fweisbec@gmail.com>,
"Ingo Molnar" <mingo@elte.hu>,
"Arnaldo Carvalho de Melo" <acme@redhat.com>
Subject: [PATCH 05/10] perf/trace/scripting: wakeup-latency script cleanup
Date: Mon, 10 May 2010 19:53:03 -0300 [thread overview]
Message-ID: <1273531987-28956-6-git-send-email-acme@infradead.org> (raw)
In-Reply-To: <1273531987-28956-1-git-send-email-acme@infradead.org>
From: Tom Zanussi <tzanussi@gmail.com>
Some minor fixes for the wakeup-latency script:
- Fix nuisance 'use of uninitialized value' warnings
- Avoid divide-by-zero error
Cc: Frédéric Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
LKML-Reference: <1273466820-9330-5-git-send-email-tzanussi@gmail.com>
Signed-off-by: Tom Zanussi <tzanussi@gmail.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/scripts/perl/wakeup-latency.pl | 12 ++++++++----
1 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/tools/perf/scripts/perl/wakeup-latency.pl b/tools/perf/scripts/perl/wakeup-latency.pl
index ed58ef2..d9143dc 100644
--- a/tools/perf/scripts/perl/wakeup-latency.pl
+++ b/tools/perf/scripts/perl/wakeup-latency.pl
@@ -22,8 +22,8 @@ my %last_wakeup;
my $max_wakeup_latency;
my $min_wakeup_latency;
-my $total_wakeup_latency;
-my $total_wakeups;
+my $total_wakeup_latency = 0;
+my $total_wakeups = 0;
sub sched::sched_switch
{
@@ -67,8 +67,12 @@ sub trace_end
{
printf("wakeup_latency stats:\n\n");
print "total_wakeups: $total_wakeups\n";
- printf("avg_wakeup_latency (ns): %u\n",
- avg($total_wakeup_latency, $total_wakeups));
+ if ($total_wakeups) {
+ printf("avg_wakeup_latency (ns): %u\n",
+ avg($total_wakeup_latency, $total_wakeups));
+ } else {
+ printf("avg_wakeup_latency (ns): N/A\n");
+ }
printf("min_wakeup_latency (ns): %u\n", $min_wakeup_latency);
printf("max_wakeup_latency (ns): %u\n", $max_wakeup_latency);
--
1.6.2.5
next prev parent reply other threads:[~2010-05-10 22:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-10 22:52 [GIT PULL 00/10] perf fixes and improvements Arnaldo Carvalho de Melo
2010-05-10 22:52 ` [PATCH 01/10] perf hist: Calculate max_sym name len and nr_entries Arnaldo Carvalho de Melo
2010-05-10 22:53 ` [PATCH 02/10] perf/trace/scripting: failed-syscalls script cleanup Arnaldo Carvalho de Melo
2010-05-10 22:53 ` [PATCH 03/10] perf/trace/scripting: rw-by-pid " Arnaldo Carvalho de Melo
2010-05-10 22:53 ` [PATCH 04/10] perf/trace/scripting: rwtop " Arnaldo Carvalho de Melo
2010-05-10 22:53 ` Arnaldo Carvalho de Melo [this message]
2010-05-10 22:53 ` [PATCH 06/10] perf/trace/scripting: workqueue-stats " Arnaldo Carvalho de Melo
2010-05-10 22:53 ` [PATCH 07/10] perf/trace/scripting: don't show script start/stop messages by default Arnaldo Carvalho de Melo
2010-05-10 22:53 ` [PATCH 08/10] perf/trace/scripting: failed-syscalls-by-pid script cleanup Arnaldo Carvalho de Melo
2010-05-10 22:53 ` [PATCH 09/10] perf/trace/scripting: syscall-counts-by-pid " Arnaldo Carvalho de Melo
2010-05-11 6:13 ` [GIT PULL 00/10] perf fixes and improvements Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273531987-28956-6-git-send-email-acme@infradead.org \
--to=acme@infradead.org \
--cc=acme@redhat.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®