mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@elte.hu, laijs@cn.fujitsu.com, dipankar@in.ibm.com,
	akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca,
	josh@joshtriplett.org, dvhltc@us.ibm.com, niv@us.ibm.com,
	tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org,
	Valdis.Kletnieks@vt.edu, dhowells@redhat.com,
	eric.dumazet@gmail.com,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	"Cc: Christoph Lameter" <cl@linux-foundation.org>,
	Pekka Enberg <penberg@cs.helsinki.fi>,
	Matt Mackall <mpm@selenic.com>
Subject: [PATCH RFC tip/core/rcu 08/11] mm: remove all rcu head initializations
Date: Tue, 11 May 2010 16:33:03 -0700	[thread overview]
Message-ID: <1273620786-20392-8-git-send-email-paulmck@linux.vnet.ibm.com> (raw)
In-Reply-To: <20100511233241.GA20250@linux.vnet.ibm.com>

Remove all rcu head inits. We don't care about the RCU head state before passing
it to call_rcu() anyway. Only leave the "on_stack" variants so debugobjects can
keep track of objects on stack.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Cc: Christoph Lameter <cl@linux-foundation.org>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Matt Mackall <mpm@selenic.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
---
 mm/backing-dev.c |    1 -
 mm/slob.c        |    1 -
 2 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/mm/backing-dev.c b/mm/backing-dev.c
index 707d0dc..f03d8d6 100644
--- a/mm/backing-dev.c
+++ b/mm/backing-dev.c
@@ -663,7 +663,6 @@ int bdi_init(struct backing_dev_info *bdi)
 	bdi->max_ratio = 100;
 	bdi->max_prop_frac = PROP_FRAC_BASE;
 	spin_lock_init(&bdi->wb_lock);
-	INIT_RCU_HEAD(&bdi->rcu_head);
 	INIT_LIST_HEAD(&bdi->bdi_list);
 	INIT_LIST_HEAD(&bdi->wb_list);
 	INIT_LIST_HEAD(&bdi->work_list);
diff --git a/mm/slob.c b/mm/slob.c
index 837ebd6..6de238d 100644
--- a/mm/slob.c
+++ b/mm/slob.c
@@ -647,7 +647,6 @@ void kmem_cache_free(struct kmem_cache *c, void *b)
 	if (unlikely(c->flags & SLAB_DESTROY_BY_RCU)) {
 		struct slob_rcu *slob_rcu;
 		slob_rcu = b + (c->size - sizeof(struct slob_rcu));
-		INIT_RCU_HEAD(&slob_rcu->head);
 		slob_rcu->size = c->size;
 		call_rcu(&slob_rcu->head, kmem_rcu_free);
 	} else {
-- 
1.7.0.6


  parent reply	other threads:[~2010-05-11 23:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-11 23:32 [PATCH tip/core/rcu 0/11] Add debugobjects checking to RCU callbacks Paul E. McKenney
2010-05-11 23:32 ` [PATCH RFC tip/core/rcu 01/11] Debugobjects transition check Paul E. McKenney
2010-05-11 23:32 ` [PATCH RFC tip/core/rcu 02/11] rcu head introduce rcu head init on stack Paul E. McKenney
2010-05-11 23:32 ` [PATCH RFC tip/core/rcu 03/11] rcu: remove all rcu head initializations, except on_stack initializations Paul E. McKenney
2010-05-11 23:32 ` [PATCH RFC tip/core/rcu 04/11] powerpc: remove all rcu head initializations Paul E. McKenney
2010-05-11 23:33 ` [PATCH RFC tip/core/rcu 05/11] block: " Paul E. McKenney
2010-05-11 23:33 ` [PATCH RFC tip/core/rcu 06/11] staging: " Paul E. McKenney
2010-05-11 23:45   ` Greg KH
2010-05-12  0:08     ` Paul E. McKenney
2010-05-14 20:16       ` Greg KH
2010-05-15 21:50         ` Paul E. McKenney
2010-05-11 23:33 ` [PATCH RFC tip/core/rcu 07/11] fs: remove all rcu head initializations, except on_stack initializations Paul E. McKenney
2010-05-11 23:33 ` Paul E. McKenney [this message]
2010-05-11 23:33 ` [PATCH RFC tip/core/rcu 09/11] selinux: remove all rcu head initializations Paul E. McKenney
2010-05-11 23:33 ` [PATCH RFC tip/core/rcu 10/11] rcu head remove init Paul E. McKenney
2010-05-11 23:33 ` [PATCH RFC tip/core/rcu 11/11] tree/tiny rcu: Add debug RCU head objects (v5) Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1273620786-20392-8-git-send-email-paulmck@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=dipankar@in.ibm.com \
    --cc=dvhltc@us.ibm.com \
    --cc=eric.dumazet@gmail.com \
    --cc=josh@joshtriplett.org \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mathieu.desnoyers@polymtl.ca \
    --cc=mingo@elte.hu \
    --cc=mpm@selenic.com \
    --cc=niv@us.ibm.com \
    --cc=penberg@cs.helsinki.fi \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®