mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tracing: Fix function declarations if !CONFIG_STACKTRACE
Date: Tue, 11 May 2010 22:26:55 -0400	[thread overview]
Message-ID: <1273631215.27703.17.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <4BE77C14.5010806@cn.fujitsu.com>

On Mon, 2010-05-10 at 11:23 +0800, Li Zefan wrote:
> ftrace_trace_stack() and frace_trace_userstacke() take a
> struct ring_buffer argument, not struct trace_array. Commit
> e77405ad("tracing: pass around ring buffer instead of tracer")
> made this change.
>
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>

Thanks Li,

I'll add this when I'm finished working on the TRACE_EVENT() updates.

-- Steve

> ---
>  kernel/trace/trace.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h
> index d1ce0be..58f6896 100644
> --- a/kernel/trace/trace.h
> +++ b/kernel/trace/trace.h
> @@ -405,12 +405,12 @@ void ftrace_trace_userstack(struct ring_buffer *buffer, unsigned long flags,
>  void __trace_stack(struct trace_array *tr, unsigned long flags, int skip,
>  		   int pc);
>  #else
> -static inline void ftrace_trace_stack(struct trace_array *tr,
> +static inline void ftrace_trace_stack(struct ring_buffer *buffer,
>  				      unsigned long flags, int skip, int pc)
>  {
>  }
>  
> -static inline void ftrace_trace_userstack(struct trace_array *tr,
> +static inline void ftrace_trace_userstack(struct ring_buffer *buffer,
>  					  unsigned long flags, int pc)
>  {
>  }



  reply	other threads:[~2010-05-12  2:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-10  3:23 Li Zefan
2010-05-12  2:26 ` Steven Rostedt [this message]
2010-05-21 17:12 ` [tip:perf/core] " tip-bot for Li Zefan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1273631215.27703.17.camel@gandalf.stny.rr.com \
    --to=rostedt@goodmis.org \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizf@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®