From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752269Ab0ELMZS (ORCPT ); Wed, 12 May 2010 08:25:18 -0400 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:33356 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751175Ab0ELMZQ (ORCPT ); Wed, 12 May 2010 08:25:16 -0400 Subject: Re: [BUG] bug when enabling VM DEBUG From: Catalin Marinas To: Sebastian Andrzej Siewior Cc: Robert Hancock , saeed bishara , linux-arm-kernel , DE/ATA development list , lkml , Jeff Garzik In-Reply-To: <20100512115340.GA11261@Chamillionaire.breakpoint.cc> References: <4BEA1559.9000107@gmail.com> <1273662639.23818.67.camel@e102109-lin.cambridge.arm.com> <20100512115340.GA11261@Chamillionaire.breakpoint.cc> Content-Type: text/plain; charset="UTF-8" Organization: ARM Limited Date: Wed, 12 May 2010 13:24:59 +0100 Message-ID: <1273667099.23818.86.camel@e102109-lin.cambridge.arm.com> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 12 May 2010 12:25:00.0020 (UTC) FILETIME=[23D50340:01CAF1CE] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2010-05-12 at 12:53 +0100, Sebastian Andrzej Siewior wrote: > * Catalin Marinas | 2010-05-12 12:10:39 [+0100]: > > >> > --- a/drivers/ata/libata-sff.c > >> > +++ b/drivers/ata/libata-sff.c > >> > @@ -894,7 +894,7 @@ static void ata_pio_sector(struct ata_queued_cmd *qc) > >> > do_write); > >> > } > >> > > >> > - if (!do_write) > >> > + if (!do_write&& !PageSlab(page)) > >> > flush_dcache_page(page); > >> > >> I would think that check belongs inside flush_dcache_page itself, rather > >> than forcing every driver to include it.. > > > >Sebastian (cc'ed) reported this as well for MIPS. > Thx. The patch above looks what I've sent a while ago. Jeff was going to > merge it afaik. > > >I think it makes sense for this check to be done in the > >flush_dcache_page() function. > > Why should flush_dcache_page() not flush pages you tell it? > From Documentation/cachetlb.txt: > | NOTE: This routine need only be called for page cache pages > | which can potentially ever be mapped into the address > | space of a user process. So for example, VFS layer code > | handling vfs symlinks in the page cache need not call > | this interface at all. > > A page from slab or stack is not going to see the sky of user land and > therefore it should not be fed into flush_dcache_page(). You are right :), so fixing the driver is the best approach. -- Catalin