mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Mark <reodge@gmail.com>
Cc: gregkh@suse.de, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org, Bernd Porr <berndporr@f2s.com>,
	Gorskin Ilya <revent82@gmail.com>
Subject: Re: [PATCH 2/2] Staging: comedi: Fixed more long line lengths in comedi.h
Date: Thu, 13 May 2010 03:40:32 -0700	[thread overview]
Message-ID: <1273747232.21514.22.camel@Joe-Laptop.home> (raw)
In-Reply-To: <1273746519-4590-2-git-send-email-reodge@gmail.com>

On Thu, 2010-05-13 at 18:28 +0800, Mark wrote:
> I'd like to get some feedback on this patch, since I'm not sure this is the best
> way to fix the long line lengths. 
> ---
>  drivers/staging/comedi/comedi.h |   15 ++++++++++-----
>  1 files changed, 10 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi/comedi.h
> index 3e3663f..ea96a83 100644
> --- a/drivers/staging/comedi/comedi.h
> +++ b/drivers/staging/comedi/comedi.h
> @@ -267,7 +267,8 @@
>  		 * streaming input/output */
>  		INSN_CONFIG_GET_HARDWARE_BUFFER_SIZE = 2006,
>  		INSN_CONFIG_SET_COUNTER_MODE = 4097,
> -		INSN_CONFIG_8254_SET_MODE = INSN_CONFIG_SET_COUNTER_MODE,	/* deprecated */
> +		/* deprecated */

			/* INSN_CONFIG_8254_SET_MODE is deprecated */

[]

> -	static inline unsigned NI_CDIO_SCAN_BEGIN_SRC_RTSI(unsigned rtsi_channel)
> +	static inline unsigned
> +		NI_CDIO_SCAN_BEGIN_SRC_RTSI(unsigned rtsi_channel)
>  	{
>  		return NI_USUAL_RTSI_SELECT(rtsi_channel);
>  	}

It'd be better to start the functions in column 1

static inline unsigned int NI_CDIO_SCAN_BEGIN_RTSI(unsigned int rtsi_channel)
{
	return NI_USUAL_RTSI_SELECT(rtsi_channel);
}


  reply	other threads:[~2010-05-13 10:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-13 10:28 [PATCH 1/2] Staging: comedi: Fixed " Mark
2010-05-13 10:28 ` [PATCH 2/2] Staging: comedi: Fixed more " Mark
2010-05-13 10:40   ` Joe Perches [this message]
2010-05-14 20:50     ` Greg KH
2010-05-14 20:51       ` Greg KH
2010-05-16 20:15         ` [PATCH] staging/comedi/comedi.h: cleanups Joe Perches
2010-05-18 21:42           ` Greg KH
2010-05-18 21:52             ` Joe Perches
2010-05-18 22:03               ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1273747232.21514.22.camel@Joe-Laptop.home \
    --to=joe@perches.com \
    --cc=berndporr@f2s.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=reodge@gmail.com \
    --cc=revent82@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®