From: Joe Perches <joe@perches.com>
To: "Prashant P. Shah" <pshah.mumbai@gmail.com>
Cc: gregkh@suse.de, bzolnier@gmail.com, Larry.Finger@lwfinger.net,
bernhard@schiffner-limbach.de, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [staging-next] [1] Staging: rtl8187se: fixed space style issues in r8180_core.c
Date: Thu, 13 May 2010 10:59:51 -0700 [thread overview]
Message-ID: <1273773591.21514.93.camel@Joe-Laptop.home> (raw)
In-Reply-To: <1273772323-6876-1-git-send-email-pshah.mumbai@gmail.com>
On Thu, 2010-05-13 at 23:08 +0530, Prashant P. Shah wrote:
> drivers/staging/rtl8187se/r8180_core.c | 1622 ++++++++++++++++----------------
> 1 files changed, 806 insertions(+), 816 deletions(-)
>
> diff --git a/drivers/staging/rtl8187se/r8180_core.c b/drivers/staging/rtl8187se/r8180_core.c
> index 84a745b..37be5ae 100644
> --- a/drivers/staging/rtl8187se/r8180_core.c
> +++ b/drivers/staging/rtl8187se/r8180_core.c
> @@ -66,23 +66,23 @@ static int hwseqnum = 0;
> static int hwwep = 0;
> static int channels = 0x3fff;
>
> -#define eqMacAddr(a,b) ( ((a)[0]==(b)[0] && (a)[1]==(b)[1] && (a)[2]==(b)[2] && (a)[3]==(b)[3] && (a)[4]==(b)[4] && (a)[5]==(b)[5]) ? 1:0 )
> -#define cpMacAddr(des,src) ((des)[0]=(src)[0],(des)[1]=(src)[1],(des)[2]=(src)[2],(des)[3]=(src)[3],(des)[4]=(src)[4],(des)[5]=(src)[5])
> +#define eqMacAddr(a, b) (((a)[0] == (b)[0] && (a)[1] == (b)[1] && (a)[2] == (b)[2] && (a)[3] == (b)[3] && (a)[4] == (b)[4] && (a)[5] == (b)[5]) ? 1 : 0)
> +#define cpMacAddr(des, src) ((des)[0] = (src)[0], (des)[1] = (src)[1], (des)[2] = (src)[2], (des)[3] = (src)[3], (des)[4] = (src)[4], (des)[5] = (src)[5])
Just use compare_ether_addr and memcpy directly
prev parent reply other threads:[~2010-05-13 17:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-13 17:38 Prashant P. Shah
2010-05-13 17:59 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273773591.21514.93.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=Larry.Finger@lwfinger.net \
--cc=bernhard@schiffner-limbach.de \
--cc=bzolnier@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pshah.mumbai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®