From: Greg Kroah-Hartman <gregkh@suse.de>
To: linux-kernel@vger.kernel.org
Cc: Anatolij Gustschin <agust@denx.de>, Greg Kroah-Hartman <gregkh@suse.de>
Subject: [PATCH 1/3] serial: mpc52xx_uart: fix null pointer dereference
Date: Thu, 13 May 2010 12:16:37 -0700 [thread overview]
Message-ID: <1273778199-17578-1-git-send-email-gregkh@suse.de> (raw)
In-Reply-To: <20100513191601.GA17538@kroah.com>
From: Anatolij Gustschin <agust@denx.de>
Commit 6acc6833510db8f72b5ef343296d97480555fda9
introduced NULL pointer dereference and kernel crash
on ppc32 machines while booting. Fix this bug now.
Reported-by: Leonardo Chiquitto <leonardo.lists@gmail.com>
Tested-by: Leonardo Chiquitto <leonardo.lists@gmail.com>
Signed-off-by: Anatolij Gustschin <agust@denx.de>
Acked-by: Grant Likely <grant.likely@secretlab.ca>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
drivers/serial/mpc52xx_uart.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/serial/mpc52xx_uart.c b/drivers/serial/mpc52xx_uart.c
index a176ab4..02469c3 100644
--- a/drivers/serial/mpc52xx_uart.c
+++ b/drivers/serial/mpc52xx_uart.c
@@ -1467,7 +1467,7 @@ mpc52xx_uart_init(void)
/*
* Map the PSC FIFO Controller and init if on MPC512x.
*/
- if (psc_ops->fifoc_init) {
+ if (psc_ops && psc_ops->fifoc_init) {
ret = psc_ops->fifoc_init();
if (ret)
return ret;
--
1.7.1
next prev parent reply other threads:[~2010-05-13 19:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-13 19:16 [GIT PATCH] TTY fixes for 2.6.34-git Greg KH
2010-05-13 19:16 ` Greg Kroah-Hartman [this message]
2010-05-13 19:16 ` [PATCH 2/3] tty: Fix unbalanced BKL handling in error path Greg Kroah-Hartman
2010-05-13 19:16 ` [PATCH 3/3] serial: imx.c: fix CTS trigger level lower to avoid lost chars Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273778199-17578-1-git-send-email-gregkh@suse.de \
--to=gregkh@suse.de \
--cc=agust@denx.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome