From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933782AbcIAL26 (ORCPT ); Thu, 1 Sep 2016 07:28:58 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:56037 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933357AbcIAL2w (ORCPT ); Thu, 1 Sep 2016 07:28:52 -0400 From: Arnd Bergmann To: Baoyou Xie Cc: b.reynal@virtualopensystems.com, alex.williamson@redhat.com, eric.auger@linaro.org, dan.carpenter@oracle.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn Subject: Re: [PATCH] vfio: platform: mark symbols static where possible Date: Thu, 01 Sep 2016 13:23:01 +0200 Message-ID: <12741269.Soyf6M0mBp@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1472728535-8584-1-git-send-email-baoyou.xie@linaro.org> References: <1472728535-8584-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:YyeqVJemm0i0q9Y6rUgTuvlh7Zb70pvThCu8ZsEnRsPcaXHLuVX 4E76vjp+YYCBukE7tu1fUIP8Q4A1wJIhffgi9tsmS6lEGkseSGGq0lGpNLeUMjKCqKag7oc f3WXAjWgy192p48DPoFmj4EOWq4GBgCBUbCu2nJVLbvmdYIKbfmvFHB53G4CXDvnc1r3wx9 h/ydizP5evlD83AV/eywA== X-UI-Out-Filterresults: notjunk:1;V01:K0:yUwV+xEhOgw=:obhcydmgcH38Qr/ILDqfqr Jzda6ULEkbUUP2xWNm8HMzL+jNl7EG+w6FRE7glkNkodNJAvQKo7W+wb7X8heMnPot1GjYqEw yJ47gn8mWW9YrqmuCCN33x4UQxTJHN8aE7tWRNbUX8yMj2FQq3NUnyKFyAWrNvgQkKywbFied KUQ/hhh1Nv/4vXzYc/g1gMmgkO3m9zG7HehOStY/EJD32PPexS3Mjuk+bgE13K8osNu6sP2B7 73hIE9zGyvWcuqt45NFaJiVxRPSqudPtczzfB0N1yDFabkK+YmPvNCm3kH3Uz93M4sSVM37e2 4ylNwVY4InFaQAHYDp6dt2xyVM0MH8mrq/gGPE+S48r8mmpQhTcknJkKBsBmj38pVCrYMum1G gSAkM3l3C8hhbLoZJv6o0dRpbx7dDvP3NKf2Ei6wphA9Pfjsllncg/k21FpHPNn32XzHK+WYM faiFSe+JivWhDfhuLrCzdYdCMdsPiVBLaqegJ3pHFQ7B/bm45FYtnYqLJgUopZbzekmTITMsV ZHFJ7zg9uNT3ZdaVBcu/fkprgcODgoscl+czLZfcTCzWosF8ivO53AlkNgv5PFRkSwnMg/s72 gN7e/vzNNZADa/Z9LJypFj7yYSKyVw9FemZV9C4w+eSv22+vm+n/LyYaXXUX1iGu7atqmgeee EjALI+qqCVCWxLb4Ek5XRr1l2ZTa/Nk80SsAXd7PIhEy/AFiusNHuaCUDhmiSdIDbrIlCVWhZ jh1HcUN4pJ+4l2rs Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, September 1, 2016 7:15:35 PM CEST Baoyou Xie wrote: > We get a few warnings when building kernel with W=1: > drivers/vfio/platform/vfio_platform_common.c:76:5: warning: no previous prototype for 'vfio_platform_acpi_call_reset' [-Wmissing-prototypes] > drivers/vfio/platform/vfio_platform_common.c:98:6: warning: no previous prototype for 'vfio_platform_acpi_has_reset' [-Wmissing-prototypes] > drivers/vfio/platform/vfio_platform_common.c:640:5: warning: no previous prototype for 'vfio_platform_of_probe' [-Wmissing-prototypes] > drivers/vfio/platform/reset/vfio_platform_amdxgbe.c:59:5: warning: no previous prototype for 'vfio_platform_amdxgbe_reset' [-Wmissing-prototypes] > drivers/vfio/platform/reset/vfio_platform_calxedaxgmac.c:60:5: warning: no previous prototype for 'vfio_platform_calxedaxgmac_reset' [-Wmissing-prototypes] > .... > > In fact, these functions are only used in the file in which they are > declared and don't need a declaration, but can be made static. > so this patch marks these functions with 'static'. > > Signed-off-by: Baoyou Xie > Acked-by: Arnd Bergmann