From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752866Ab0ESO4N (ORCPT ); Wed, 19 May 2010 10:56:13 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.123]:48249 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752175Ab0ESO4M (ORCPT ); Wed, 19 May 2010 10:56:12 -0400 X-Authority-Analysis: v=1.1 cv=APwCx09NCuKDvl2mjFwkKdJZScS8XOZHPgx3WG6BpL0= c=1 sm=0 a=8EtQVlZUVNwA:10 a=hO-oPbc3tlwA:10 a=7U3hwN5JcxgA:10 a=Q9fys5e9bTEA:10 a=gMqfjgEr1zLu/65IO0LwxA==:17 a=0_atlRnjNRK3KSvZqngA:9 a=bkT0IEqUNN8wu51UCvEau_KDZuAA:4 a=PUjeQqilurYA:10 a=gMqfjgEr1zLu/65IO0LwxA==:117 X-Cloudmark-Score: 0 X-Originating-IP: 74.67.89.75 Subject: Re: Unexpected splice "always copy" behavior observed From: Steven Rostedt Reply-To: rostedt@goodmis.org To: Linus Torvalds Cc: Nick Piggin , Mathieu Desnoyers , Peter Zijlstra , Frederic Weisbecker , Pierre Tardy , Ingo Molnar , Arnaldo Carvalho de Melo , Tom Zanussi , Paul Mackerras , linux-kernel@vger.kernel.org, arjan@infradead.org, ziga.mahkovec@gmail.com, davem , linux-mm@kvack.org, Andrew Morton , KOSAKI Motohiro , Christoph Lameter , Tejun Heo , Jens Axboe In-Reply-To: References: <20100518153440.GB7748@Krystal> <1274197993.26328.755.camel@gandalf.stny.rr.com> <1274199039.26328.758.camel@gandalf.stny.rr.com> <20100519063116.GR2516@laptop> Content-Type: text/plain; charset="ISO-8859-15" Organization: Kihon Technologies Inc. Date: Wed, 19 May 2010 10:56:08 -0400 Message-ID: <1274280968.26328.774.camel@gandalf.stny.rr.com> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2010-05-19 at 07:39 -0700, Linus Torvalds wrote: > The real limitation is likely always going to be the fact that it has to > be page-aligned and a full page. For a lot of splice inputs, that simply > won't be the case, and you'll end up copying for alignment reasons anyway. That's understandable. For the use cases of splice I use, I work to make it page aligned and full pages. Anyone else using splice for optimizations, should do the same. It only makes sense. The end of buffer may not be a full page, but then it's the end anyway, and I'm not as interested in the speed. -- Steve