From: Frederic Weisbecker <fweisbec@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Paul Mackerras <paulus@samba.org>
Subject: [PATCH 3/4] perf: Support for irq exclusion
Date: Fri, 21 May 2010 16:05:14 +0200 [thread overview]
Message-ID: <1274450715-23955-4-git-send-regression-fweisbec@gmail.com> (raw)
In-Reply-To: <1274450715-23955-1-git-send-regression-fweisbec@gmail.com>
Provide exclude_softirq and exclude_hardirq support in perf
event attributes. This brings the final pieces to subscribe
to any desired context granularity of profiling or tracing.
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
---
include/linux/perf_event.h | 8 +++++---
kernel/perf_event.c | 42 +++++++++++++++++++++++++++++++-----------
2 files changed, 36 insertions(+), 14 deletions(-)
diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
index d939fc7..ca55ec5 100644
--- a/include/linux/perf_event.h
+++ b/include/linux/perf_event.h
@@ -213,10 +213,12 @@ struct perf_event_attr {
*
* See also PERF_RECORD_MISC_EXACT_IP
*/
- precise_ip : 2, /* skid constraint */
- exclude_task : 1, /* don't count task context */
+ precise_ip : 2, /* skid constraint */
+ exclude_task : 1, /* don't count task context */
+ exclude_softirq : 1, /* don't count softirq */
+ exclude_hardirq : 1, /* don't count hardirq */
- __reserved_1 : 46;
+ __reserved_1 : 45;
union {
__u32 wakeup_events; /* wakeup every n events */
diff --git a/kernel/perf_event.c b/kernel/perf_event.c
index ab96411..03c17b2 100644
--- a/kernel/perf_event.c
+++ b/kernel/perf_event.c
@@ -3837,16 +3837,9 @@ static void perf_log_throttle(struct perf_event *event, int enable)
perf_output_end(&handle);
}
-/*
- * Generic event overflow handling, sampling.
- */
-
-static int __perf_event_overflow(struct perf_event *event, int nmi,
- int throttle, struct perf_sample_data *data,
- struct pt_regs *regs)
+static int perf_event_unthrottle(struct perf_event *event,
+ struct hw_perf_event *hwc, int throttle)
{
- int events = atomic_read(&event->event_limit);
- struct hw_perf_event *hwc = &event->hw;
int ret = 0;
throttle = (throttle && event->pmu->unthrottle != NULL);
@@ -3872,6 +3865,23 @@ static int __perf_event_overflow(struct perf_event *event, int nmi,
}
}
+ return ret;
+}
+
+/*
+ * Generic event overflow handling, sampling.
+ */
+
+static int __perf_event_overflow(struct perf_event *event, int nmi,
+ int throttle, struct perf_sample_data *data,
+ struct pt_regs *regs)
+{
+ int events = atomic_read(&event->event_limit);
+ struct hw_perf_event *hwc = &event->hw;
+ int ret;
+
+ ret = perf_event_unthrottle(event, &event->hw, throttle);
+
if (event->attr.freq) {
u64 now = perf_clock();
s64 delta = now - hwc->freq_time_stamp;
@@ -3910,9 +3920,19 @@ static int __perf_event_overflow(struct perf_event *event, int nmi,
static bool
perf_exclude_event(struct perf_event *event, int offset)
{
- if (!in_interrupt_offset(preempt_count() - offset)) {
+ int preempt_offset = preempt_count() - offset;
+
+ if (!in_interrupt_offset(preempt_offset)) {
if (event->attr.exclude_task)
return true;
+ } else {
+ if (in_irq_offset(preempt_offset)) {
+ if (event->attr.exclude_hardirq)
+ return true;
+ } else if (in_softirq_offset(preempt_offset)) {
+ if (event->attr.exclude_softirq)
+ return true;
+ }
}
return false;
@@ -3932,7 +3952,7 @@ int perf_event_overflow(struct perf_event *event, int nmi,
* context.
*/
if (perf_exclude_event(event, offset))
- return 0;
+ return perf_event_unthrottle(event, &event->hw, 1);
return __perf_event_overflow(event, nmi, 1, data, regs);
}
--
1.6.2.3
next prev parent reply other threads:[~2010-05-21 14:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-21 14:05 [PATCH 0/4] perf: Tasks and " Frederic Weisbecker
2010-05-21 14:05 ` [PATCH 1/4] irq: Support to compute context on top of a given preempt_count offset Frederic Weisbecker
2010-05-21 14:05 ` [PATCH 2/4] perf: Add exclude_task perf event attribute Frederic Weisbecker
2010-05-25 1:43 ` Paul Mackerras
2010-05-25 6:58 ` Peter Zijlstra
2010-05-25 10:06 ` Frederic Weisbecker
2010-06-07 1:38 ` Frederic Weisbecker
2010-06-08 18:59 ` Ingo Molnar
2010-06-08 19:02 ` Frederic Weisbecker
2010-05-21 14:05 ` Frederic Weisbecker [this message]
2010-05-21 14:06 ` [PATCH 3/4] perf: Support for irq exclusion Frederic Weisbecker
2010-05-21 14:05 ` [PATCH 4/4] perf: Support for task/softirq/hardirq exclusion on tools Frederic Weisbecker
2010-05-21 15:12 ` [PATCH 0/4] perf: Precise task / softirq / hardirq filtered stats/profiles Ingo Molnar
2010-05-21 16:15 ` Peter Zijlstra
2010-05-21 18:36 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274450715-23955-4-git-send-regression-fweisbec@gmail.com \
--to=fweisbec@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome