mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michel Lespinasse <walken@google.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
	David Howells <dhowells@redhat.com>, Ingo Molnar <mingo@elte.hu>,
	Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Mike Waychison <mikew@google.com>,
	Suleiman Souhlal <suleiman@google.com>,
	Ying Han <yinghan@google.com>
Subject: [PATCH 01/11] x86 rwsem: stay on fast path when count>0 in __up_write()
Date: Mon, 24 May 2010 13:31:11 -0700	[thread overview]
Message-ID: <1274733081-4623-2-git-send-email-walken@google.com> (raw)
In-Reply-To: <1274733081-4623-1-git-send-email-walken@google.com>

When count>0 there is no need to take the call_rwsem_wake path.
If we did take that path, it would just return without doing anything
due to the active count not being zero.

Signed-off-by: Michel Lespinasse <walken@google.com>
Acked-by: David Howells <dhowells@redhat.com>
---
 arch/x86/include/asm/rwsem.h |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/x86/include/asm/rwsem.h b/arch/x86/include/asm/rwsem.h
index 606ede1..3fd1ed3 100644
--- a/arch/x86/include/asm/rwsem.h
+++ b/arch/x86/include/asm/rwsem.h
@@ -216,9 +216,8 @@ static inline void __up_write(struct rw_semaphore *sem)
 	rwsem_count_t tmp;
 	asm volatile("# beginning __up_write\n\t"
 		     LOCK_PREFIX "  xadd      %1,(%2)\n\t"
-		     /* tries to transition
-			0xffff0001 -> 0x00000000 */
-		     "  jz       1f\n"
+		     /* substracts 0xffff0001, returns the old value */
+		     "  jns        1f\n\t"
 		     "  call call_rwsem_wake\n"
 		     "1:\n\t"
 		     "# ending __up_write\n"
-- 
1.7.0.1


  reply	other threads:[~2010-05-24 20:32 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-24 20:31 [PATCH 00/11] V4: rwsem changes + down_read_critical() proposal Michel Lespinasse
2010-05-24 20:31 ` Michel Lespinasse [this message]
2010-05-24 20:31 ` [PATCH 02/11] x86 rwsem: minor cleanups Michel Lespinasse
2010-05-24 20:31 ` [PATCH 03/11] rwsem: fully separate code pathes to wake writers vs readers Michel Lespinasse
2010-05-24 20:31 ` [PATCH 04/11] rwsem: lighter active count checks when waking up readers Michel Lespinasse
2010-05-24 20:49   ` Daniel Walker
2010-05-24 20:31 ` [PATCH 05/11] rwsem: let RWSEM_WAITING_BIAS represent any number of waiting threads Michel Lespinasse
2010-05-24 20:31 ` [PATCH 06/11] rwsem: wake queued readers when writer blocks on active read lock Michel Lespinasse
2010-08-12  1:24   ` Tony Luck
2010-08-12  5:02     ` Michel Lespinasse
2010-08-12  5:09       ` Michel Lespinasse
2010-08-12 15:57         ` Linus Torvalds
2010-08-12 16:24           ` Tony Luck
2010-08-12 22:23             ` Tony Luck
2010-08-13 16:09               ` Tony Luck
2010-08-13 21:19                 ` Tony Luck
2010-08-13 23:38                   ` Tony Luck
2010-08-13 23:48                     ` Michel Lespinasse
2010-08-12 16:22       ` Tony Luck
2010-05-24 20:31 ` [PATCH 07/11] rwsem: smaller wrappers around rwsem_down_failed_common Michel Lespinasse
2010-05-24 20:31 ` [PATCH 08/11] generic rwsem: implement down_read_critical() / up_read_critical() Michel Lespinasse
2010-05-24 20:31 ` [PATCH 09/11] rwsem: down_read_critical infrastructure support Michel Lespinasse
2010-05-24 20:31 ` [PATCH 10/11] x86 rwsem: down_read_critical implementation Michel Lespinasse
2010-05-24 20:31 ` [PATCH 11/11] Use down_read_critical() for /proc/<pid>/exe and /proc/<pid>/maps files Michel Lespinasse
2010-05-24 21:12   ` Daniel Walker
2010-05-27 14:12   ` Arjan van de Ven
2010-05-25  8:47 ` [PATCH 00/11] V4: rwsem changes + down_read_critical() proposal Peter Zijlstra
2010-05-25  9:12   ` Michel Lespinasse
2010-05-25  9:27     ` Peter Zijlstra
2010-05-26  1:23       ` KAMEZAWA Hiroyuki
2010-05-27 11:02         ` Michel Lespinasse
2010-05-27 11:45           ` Peter Zijlstra
2010-05-27 10:59       ` Michel Lespinasse
2010-05-27 11:18         ` Peter Zijlstra
2010-05-27 11:47           ` Michel Lespinasse
2010-05-25 15:16   ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1274733081-4623-2-git-send-email-walken@google.com \
    --to=walken@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikew@google.com \
    --cc=mingo@elte.hu \
    --cc=suleiman@google.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=yinghan@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome