From: Artem Bityutskiy <dedekind1@gmail.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: LKML <linux-kernel@vger.kernel.org>,
Jens Axboe <jens.axboe@oracle.com>,
linux-fsdevel@vger.kernel.org,
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Subject: [PATCHv4 08/17] FAT: do not manipulate s_dirt directly
Date: Tue, 25 May 2010 16:49:03 +0300 [thread overview]
Message-ID: <1274795352-3551-9-git-send-email-dedekind1@gmail.com> (raw)
In-Reply-To: <1274795352-3551-1-git-send-email-dedekind1@gmail.com>
From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
... use new VFS helpers instead.
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Cc: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
---
fs/fat/fatent.c | 8 ++++----
fs/fat/inode.c | 8 ++++----
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/fs/fat/fatent.c b/fs/fat/fatent.c
index 81184d3..4a63301 100644
--- a/fs/fat/fatent.c
+++ b/fs/fat/fatent.c
@@ -498,7 +498,7 @@ int fat_alloc_clusters(struct inode *inode, int *cluster, int nr_cluster)
sbi->prev_free = entry;
if (sbi->free_clusters != -1)
sbi->free_clusters--;
- sb->s_dirt = 1;
+ mark_sb_dirty(sb);
cluster[idx_clus] = entry;
idx_clus++;
@@ -520,7 +520,7 @@ int fat_alloc_clusters(struct inode *inode, int *cluster, int nr_cluster)
/* Couldn't allocate the free entries */
sbi->free_clusters = 0;
sbi->free_clus_valid = 1;
- sb->s_dirt = 1;
+ mark_sb_dirty(sb);
err = -ENOSPC;
out:
@@ -586,7 +586,7 @@ int fat_free_clusters(struct inode *inode, int cluster)
ops->ent_put(&fatent, FAT_ENT_FREE);
if (sbi->free_clusters != -1) {
sbi->free_clusters++;
- sb->s_dirt = 1;
+ mark_sb_dirty(sb);
}
if (nr_bhs + fatent.nr_bhs > MAX_BUF_PER_PAGE) {
@@ -676,7 +676,7 @@ int fat_count_free_clusters(struct super_block *sb)
}
sbi->free_clusters = free;
sbi->free_clus_valid = 1;
- sb->s_dirt = 1;
+ mark_sb_dirty(sb);
fatent_brelse(&fatent);
out:
unlock_fat(sbi);
diff --git a/fs/fat/inode.c b/fs/fat/inode.c
index 0ce143b..ea634fe 100644
--- a/fs/fat/inode.c
+++ b/fs/fat/inode.c
@@ -442,7 +442,7 @@ static void fat_clear_inode(struct inode *inode)
static void fat_write_super(struct super_block *sb)
{
lock_super(sb);
- sb->s_dirt = 0;
+ mark_sb_clean(sb);
if (!(sb->s_flags & MS_RDONLY))
fat_clusters_flush(sb);
@@ -453,9 +453,9 @@ static int fat_sync_fs(struct super_block *sb, int wait)
{
int err = 0;
- if (sb->s_dirt) {
+ if (is_sb_dirty(sb)) {
lock_super(sb);
- sb->s_dirt = 0;
+ mark_sb_clean(sb);
err = fat_clusters_flush(sb);
unlock_super(sb);
}
@@ -469,7 +469,7 @@ static void fat_put_super(struct super_block *sb)
lock_kernel();
- if (sb->s_dirt)
+ if (is_sb_dirty(sb))
fat_write_super(sb);
iput(sbi->fat_inode);
--
1.6.6.1
next prev parent reply other threads:[~2010-05-25 13:51 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-25 13:48 [PATCHv4 00/17] kill unnecessary SB sync wake-ups Artem Bityutskiy
2010-05-25 13:48 ` [PATCHv4 01/17] VFS: introduce helpers for the s_dirty flag Artem Bityutskiy
2010-05-28 20:23 ` Andrew Morton
2010-05-28 21:14 ` Al Viro
2010-05-28 21:17 ` Andrew Morton
2010-05-29 8:11 ` Artem Bityutskiy
2010-06-09 15:44 ` tytso
2010-06-09 15:49 ` Artem Bityutskiy
2010-06-09 16:31 ` Andrew Morton
2010-06-09 22:33 ` Al Viro
2010-05-29 7:59 ` Artem Bityutskiy
2010-05-25 13:48 ` [PATCHv4 02/17] AFFS: do not manipulate s_dirt directly Artem Bityutskiy
2010-05-25 13:48 ` [PATCHv4 03/17] BFS: " Artem Bityutskiy
2010-05-25 13:48 ` [PATCHv4 04/17] BTRFS: " Artem Bityutskiy
2010-05-25 13:49 ` [PATCHv4 05/17] EXOFS: " Artem Bityutskiy
2010-05-26 15:12 ` Boaz Harrosh
2010-05-25 13:49 ` [PATCHv4 06/17] EXT2: " Artem Bityutskiy
2010-05-25 13:49 ` [PATCHv4 07/17] EXT4: " Artem Bityutskiy
2010-05-25 13:49 ` Artem Bityutskiy [this message]
2010-05-25 13:49 ` [PATCHv4 09/17] HFS: " Artem Bityutskiy
2010-05-25 13:49 ` [PATCHv4 10/17] HFSPLUS: " Artem Bityutskiy
2010-05-25 13:49 ` [PATCHv4 11/17] JFFS2: " Artem Bityutskiy
2010-05-25 13:49 ` [PATCHv4 12/17] reiserfs: " Artem Bityutskiy
2010-05-25 13:49 ` [PATCHv4 13/17] SYSV: " Artem Bityutskiy
2010-05-25 13:49 ` [PATCHv4 14/17] UDF: " Artem Bityutskiy
2010-05-25 14:06 ` Jan Kara
2010-05-25 13:49 ` [PATCHv4 15/17] UFS: " Artem Bityutskiy
2010-05-25 13:49 ` [PATCHv4 16/17] VFS: rename s_dirt to s_dirty Artem Bityutskiy
2010-05-25 13:49 ` [PATCHv4 17/17] writeback: lessen sync_supers wakeup count Artem Bityutskiy
2010-05-27 6:50 ` Al Viro
2010-05-27 7:22 ` Nick Piggin
2010-05-27 9:08 ` Al Viro
2010-05-27 10:51 ` Artem Bityutskiy
2010-05-27 12:07 ` Nick Piggin
2010-05-27 15:21 ` Artem Bityutskiy
2010-05-27 15:44 ` Nick Piggin
2010-05-27 16:04 ` Artem Bityutskiy
2010-05-31 8:25 ` Artem Bityutskiy
2010-05-31 8:38 ` Nick Piggin
2010-05-31 9:04 ` Artem Bityutskiy
2010-05-31 12:47 ` Nick Piggin
2010-05-31 13:03 ` Artem Bityutskiy
2010-05-27 10:19 ` Artem Bityutskiy
2010-05-31 14:07 ` Artem Bityutskiy
2010-06-04 4:26 ` Al Viro
2010-06-04 5:13 ` Artem Bityutskiy
2010-05-28 20:29 ` Andrew Morton
2010-05-29 8:03 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274795352-3551-9-git-send-email-dedekind1@gmail.com \
--to=dedekind1@gmail.com \
--cc=hirofumi@mail.parknet.co.jp \
--cc=jens.axboe@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome