mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Jeffrey Merkey <jeffmerkey@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: Question about SIOCGIFCONF
Date: Fri, 28 May 2010 06:57:31 +0200	[thread overview]
Message-ID: <1275022651.2446.35.camel@edumazet-laptop> (raw)
In-Reply-To: <AANLkTinUsKL0kqAjRG95xcrqjWPUlNn1TPD21wIJjShS@mail.gmail.com>

Le jeudi 27 mai 2010 à 21:02 -0600, Jeffrey Merkey a écrit :
> Why is SIOGICONF only instrumented to return a single interface lo for
> example.  I noticed that ifconfig always uses /proc/net/dev but the
> older SIOCGIFCONF ioctl seems to be busted.  Anyone have an
> explanation or is this just how the shit is these days or is the
> fucking thing broken (seems to be). ?

Shit comes from you eyes maybe ?

Correction : Shit comes from your eyes, definitely.

Proof :

# strace -o /tmp/STRACE ifconfig -a
# grep SIOCGIFCONF /tmp/STRACE
ioctl(4, SIOCGIFCONF, {120, {{"lo", {AF_INET, inet_addr("127.0.0.1")}},
{"wlan0", {AF_INET, inet_addr("192.168.1.21")}}, {"ppp0", {AF_INET,
inet_addr("10.150.51.210")}}}}) = 0


Part of ifconfig :

    ifc.ifc_buf = NULL;
    for (;;) {
        ifc.ifc_len = sizeof(struct ifreq) * numreqs;
        ifc.ifc_buf = xrealloc(ifc.ifc_buf, ifc.ifc_len);

        if (ioctl(skfd, SIOCGIFCONF, &ifc) < 0) {
            perror("SIOCGIFCONF");
            goto out;
        }
        if (ifc.ifc_len == sizeof(struct ifreq) * numreqs) {
            /* assume it overflowed and try again */
            numreqs += 10;
            continue;
        }
        break;
    }

maybe numreqs should be firt initialized to 64, then doubled each
round...



  reply	other threads:[~2010-05-28  4:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-28  3:02 Jeffrey Merkey
2010-05-28  4:57 ` Eric Dumazet [this message]
2010-05-28  9:22   ` Steven Whitehouse
2010-05-28 18:31   ` Jeffrey Merkey
2010-05-28 19:02     ` Jeffrey Merkey
2010-05-28 19:05       ` Jeffrey Merkey
2010-05-28 20:06         ` Eric Dumazet
     [not found]           ` <AANLkTimg3iNFVcV7AWSc0MPoW7UwunwSdH4NNIxl_w-P@mail.gmail.com>
2010-05-28 22:00             ` Fwd: " Jeffrey Merkey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1275022651.2446.35.camel@edumazet-laptop \
    --to=eric.dumazet@gmail.com \
    --cc=jeffmerkey@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®