From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751596Ab0E2Eah (ORCPT ); Sat, 29 May 2010 00:30:37 -0400 Received: from mail-pz0-f204.google.com ([209.85.222.204]:35540 "EHLO mail-pz0-f204.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751236Ab0E2EaT (ORCPT ); Sat, 29 May 2010 00:30:19 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; b=ifZzV5qalOZrWMjFVEPTvoBvpzW4SJEP/S0F971kntKPs50bSxQHAZx3vEbwqYoWiQ tqBFu+myil5wklwVXEpU8GG3+0T0mUuziO0z30YrEX/lZ4g2W7XxWC1cIXz2rdNjWMRs GRPBGYL1b4F80r2ccdnXK8WqjZ7GC7xE3cn3Y= From: Akinobu Mita To: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux390@de.ibm.com, linux-s390@vger.kernel.org Cc: Akinobu Mita Subject: [PATCH 1/2] char: add WARN_ON() in misc_deregister() Date: Sat, 29 May 2010 13:28:50 +0900 Message-Id: <1275107331-5045-1-git-send-email-akinobu.mita@gmail.com> X-Mailer: git-send-email 1.6.0.6 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org misc_deregister() returns an error only when it attempts to unregister the device that is not registered. This is the driver's bug. Most of the drivers don't check the return value of misc_deregister(). (It is not bad thing because most of kernel *_unregister() API always succeed and do not return value) So it is better to indicate the error by WARN_ON() in misc_deregister(). Signed-off-by: Akinobu Mita --- drivers/char/misc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/char/misc.c b/drivers/char/misc.c index cd650ca..abdafd4 100644 --- a/drivers/char/misc.c +++ b/drivers/char/misc.c @@ -242,7 +242,7 @@ int misc_deregister(struct miscdevice *misc) { int i = DYNAMIC_MINORS - misc->minor - 1; - if (list_empty(&misc->list)) + if (WARN_ON(list_empty(&misc->list))) return -EINVAL; mutex_lock(&misc_mtx); -- 1.6.0.6