From: Peter Zijlstra <peterz@infradead.org>
To: Venkatesh Pallipadi <venki@google.com>
Cc: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
suresh.b.siddha@intel.com, tglx@linutronix.de,
linux-tip-commits@vger.kernel.org,
Fabio Checconi <fabio@gandalf.sssup.it>
Subject: Re: [PATCH] rbtree: undo augmented damage -v2
Date: Tue, 01 Jun 2010 19:34:10 +0200 [thread overview]
Message-ID: <1275413650.27810.27930.camel@twins> (raw)
In-Reply-To: <1275412748.27810.27883.camel@twins>
On Tue, 2010-06-01 at 19:19 +0200, Peter Zijlstra wrote:
> On Tue, 2010-06-01 at 10:00 -0700, Venkatesh Pallipadi wrote:
> > I am not seeing how this can cover all the callbacks we will need to
> > maintain the augmented tree property. May be I am missing something.
>
> Yes, indeed, how about the below delta, which my eevdf code did do but I
> overlooked on the conversion to the PAT code.
>
> That removes the break as you said, but also adds code to update the
> child nodes when walking up the path.
>
> So in your rotation case:
>
> G P
> / \ --> / \
> P U N G
> / <-- \
> N U
>
> Say we take the right rotation, then the traversal up from N to P will
> find that since N was the left child of P and it has a right child (G)
> it will also update G.
Hmm, that looks like it could well be folded in to the generic code..
let me spin a new patch.
next prev parent reply other threads:[~2010-06-01 17:34 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-10 19:57 [patch 0/3] x86: Use interval tree to keep track of PAT reserve/free venkatesh.pallipadi
2010-02-10 19:57 ` [patch 1/3] rbtree: Add support for augmented rbtrees venkatesh.pallipadi
2010-02-10 23:23 ` [patch 1/3] rbtree: Add support for augmented rbtrees (ver 2) Pallipadi, Venkatesh
2010-02-19 0:21 ` [tip:x86/pat] rbtree: Add support for augmented rbtrees tip-bot for Pallipadi, Venkatesh
2010-05-27 15:29 ` Peter Zijlstra
2010-05-29 12:29 ` [RFC][PATCH] rbtree: undo augmented damage Peter Zijlstra
2010-05-29 13:31 ` [PATCH] rbtree: undo augmented damage -v2 Peter Zijlstra
2010-06-01 17:00 ` Venkatesh Pallipadi
2010-06-01 17:19 ` Peter Zijlstra
2010-06-01 17:34 ` Peter Zijlstra [this message]
2010-06-01 17:34 ` Venkatesh Pallipadi
2010-06-01 17:42 ` Peter Zijlstra
2010-06-01 18:09 ` Venkatesh Pallipadi
2010-06-01 18:42 ` Peter Zijlstra
2010-06-01 20:31 ` Venkatesh Pallipadi
2010-06-02 21:11 ` Suresh Siddha
2010-06-03 1:15 ` Venkatesh Pallipadi
2010-06-03 7:13 ` Peter Zijlstra
2010-06-03 7:48 ` Peter Zijlstra
2010-06-03 16:04 ` Suresh Siddha
2010-06-09 10:12 ` [tip:x86/pat] rbtree: Undo augmented trees performance damage tip-bot for Peter Zijlstra
2010-07-05 12:48 ` [tip:x86/urgent] rbtree: Undo augmented trees performance damage and regression tip-bot for Peter Zijlstra
2010-02-10 19:57 ` [patch 2/3] x86: Preparatory changes in pat.c for bigger rbtree change venkatesh.pallipadi
2010-02-19 0:22 ` [tip:x86/pat] x86, pat: " tip-bot for venkatesh.pallipadi@intel.com
2010-02-10 19:57 ` [patch 3/3] x86: Migrate to rbtree only backend for pat memtype management venkatesh.pallipadi
2010-02-10 23:26 ` [patch 3/3] x86: Migrate to rbtree only backend for pat memtype management (ver 2) Pallipadi, Venkatesh
2010-02-19 0:22 ` [tip:x86/pat] x86, pat: Migrate to rbtree only backend for pat memtype management tip-bot for Pallipadi, Venkatesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275413650.27810.27930.camel@twins \
--to=peterz@infradead.org \
--cc=fabio@gandalf.sssup.it \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=venki@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome