mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: linux-kernel@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>,
	linux-usb@vger.kernel.org,
	Frederic Weisbecker <fweisbec@gmail.com>,
	John Kacur <jkacur@redhat.com>, Ingo Molnar <mingo@elte.hu>,
	Jan Blunck <jblunck@suse.de>
Subject: [RFC 3/5] BKL: do not take BKL in do_coredump
Date: Thu,  3 Jun 2010 02:13:17 +0200	[thread overview]
Message-ID: <1275523999-27462-4-git-send-email-arnd@arndb.de> (raw)
In-Reply-To: <1275523999-27462-1-git-send-email-arnd@arndb.de>

core_pattern is not actually protected and hasn't been
ever since we introduced procfs support for sysctl -- a
_long_ time. Don't take it here either.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 fs/exec.c |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/fs/exec.c b/fs/exec.c
index e19de6a..3d7aeeb 100644
--- a/fs/exec.c
+++ b/fs/exec.c
@@ -1891,13 +1891,7 @@ void do_coredump(long signr, int exit_code, struct pt_regs *regs)
 	 */
 	clear_thread_flag(TIF_SIGPENDING);
 
-	/*
-	 * lock_kernel() because format_corename() is controlled by sysctl, which
-	 * uses lock_kernel()
-	 */
- 	lock_kernel();
 	ispipe = format_corename(corename, signr);
-	unlock_kernel();
 
  	if (ispipe) {
 		int dump_count;
-- 
1.7.0.4


  parent reply	other threads:[~2010-06-03  0:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-03  0:13 [RFC 0/5] BKL removal leftovers Arnd Bergmann
2010-06-03  0:13 ` [RFC 1/5] BKL: autoconvert trivial users to private mutex Arnd Bergmann
2010-06-03  0:35   ` Frederic Weisbecker
2010-06-03 16:50     ` Greg KH
2010-06-03  0:13 ` [RFC 2/5] BKL: remove the BKL from kernel init code Arnd Bergmann
2010-06-03  1:07   ` Steven Rostedt
2010-06-03  0:13 ` Arnd Bergmann [this message]
2010-06-03  0:13 ` [RFC 4/5] BKL: use no BKL in llseek Arnd Bergmann
2010-06-03  0:38   ` Frederic Weisbecker
2010-06-03  7:08     ` Christoph Hellwig
2010-06-03  7:06   ` Christoph Hellwig
2010-06-03 23:47     ` Arnd Bergmann
2010-06-03  7:41   ` Geert Uytterhoeven
2010-06-03  0:13 ` [RFC 5/5] BKL: introduce CONFIG_BKL Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1275523999-27462-4-git-send-email-arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=fweisbec@gmail.com \
    --cc=jblunck@suse.de \
    --cc=jkacur@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®