Re: [PATCH] kobject: Suppress compiler warning with gcc 3.x

[Eric Dumazet <eric.dumazet@gmail.com>]

Le jeudi 03 juin 2010 à 14:23 +0900, Tetsuo Handa a écrit :
> Gcc 3.x generates a warning
> 
>   include/linux/sysfs.h:183: warning: parameter has incomplete type
> 
> on each file.
> Suppress the warning by moving the definition of "enum kobj_ns_type"
> to before "#include <linux/sysfs.h>".
> 
> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>


I was about to submit same patch, but I was also reverting 27eabc7cb4b3
(sysfs: Don't use enums in inline function declaration.)

So that sysfs_exit_ns() prototype is consistent regardless of
CONFIG_SYSFS

What do you think ?


> ---
>  include/linux/kobject.h |   20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> --- linux-2.6.35-rc1.orig/include/linux/kobject.h
> +++ linux-2.6.35-rc1/include/linux/kobject.h
> @@ -16,6 +16,16 @@
>  #ifndef _KOBJECT_H_
>  #define _KOBJECT_H_
>  
> +/*
> + * Namespace types which are used to tag kobjects and sysfs entries.
> + * Network namespace will likely be the first.
> + */
> +enum kobj_ns_type {
> +	KOBJ_NS_TYPE_NONE = 0,
> +	KOBJ_NS_TYPE_NET,
> +	KOBJ_NS_TYPES
> +};
> +
>  #include <linux/types.h>
>  #include <linux/list.h>
>  #include <linux/sysfs.h>
> @@ -136,16 +146,6 @@ struct kobj_attribute {
>  
>  extern const struct sysfs_ops kobj_sysfs_ops;
>  
> -/*
> - * Namespace types which are used to tag kobjects and sysfs entries.
> - * Network namespace will likely be the first.
> - */
> -enum kobj_ns_type {
> -	KOBJ_NS_TYPE_NONE = 0,
> -	KOBJ_NS_TYPE_NET,
> -	KOBJ_NS_TYPES
> -};
> -
>  struct sock;
>  
>  /*