From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756639Ab0FHV03 (ORCPT ); Tue, 8 Jun 2010 17:26:29 -0400 Received: from mail.perches.com ([173.55.12.10]:2821 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750925Ab0FHV02 (ORCPT ); Tue, 8 Jun 2010 17:26:28 -0400 Subject: Re: [PATCH 00/17] MAINTAINERS: Add drivers/staging entries From: Joe Perches To: Greg KH Cc: Andrew Morton , Andrew Lunn , Jarod Wilson , Jakub Schmidtke , Henk de Groot , Naren Sankar , Jonathan Cameron , Pavel Machek , Luis Rodriguez , devel@driverdev.osuosl.org, Mori Hess , Steve Underwood , Simon Wunderlich , Arnaud Patard , Marek Lindner , Teddy Wang , Ossama Othman , Haiyang Zhang , Ian Abbott , Willy Tarreau , Scott Davilla , Scott Smedley , linux-kernel@vger.kernel.org, Forest Bond , David Rowe In-Reply-To: <20100608211246.GC10657@kroah.com> References: <20100608211246.GC10657@kroah.com> Content-Type: text/plain; charset="UTF-8" Date: Tue, 08 Jun 2010 14:26:22 -0700 Message-ID: <1276032382.24044.23.camel@Joe-Laptop.home> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2010-06-08 at 14:12 -0700, Greg KH wrote: > On Mon, Jun 07, 2010 at 11:49:34AM -0700, Joe Perches wrote: > > Some drivers/staging directories use a TODO file with email entries. > > Make the same entries in the normal MAINTAINERS file. > > No, please don't do this. I don't want to clutter up the MAINTAINERS > file with staging stuff. It's not clutter when it helps get patches to the right reviewers or responsible parties. > The get_maintainer.pl script handles staging > patches just fine today without this being needed at all. Dubious. Many of these nominal maintainer email entries are not found in git logs. For instance: $ grep "@" drivers/staging/dt3155/TODO Please send patches to Greg Kroah-Hartman and Scott Smedley $ ./scripts/get_maintainer.pl -f drivers/staging/dt3155/ Greg Kroah-Hartman Simon Horman H Hartley Sweeten devel@driverdev.osuosl.org linux-kernel@vger.kernel.org Some have cc:'d entries, but not many actually have Signed-off-by's. Perhaps that's because the individuals are not frequently cc'd on the actual patches. Perhaps because the people that put their names in the TODO's just don't care. > I also found it a bit odd you didn't send these to the stable subsystem > maintainer, why? The MAINTAINERS patches are forward going, not historical. cheers, Joe