From: Joe Perches <joe@perches.com>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: Fredrik Gustafsson <iveqy@iveqy.com>,
apw@canonical.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch.pl skip long lines
Date: Sat, 12 Jun 2010 22:36:12 -0700 [thread overview]
Message-ID: <1276407372.1449.33.camel@Joe-Laptop.home> (raw)
In-Reply-To: <20100613010429.GA31692@pengutronix.de>
On Sun, 2010-06-13 at 03:04 +0200, Wolfram Sang wrote:
> On Sat, Jun 12, 2010 at 07:09:44PM +0200, Fredrik Gustafsson wrote:
>
> > since the number of long lines in the linux kernel is huge and since
> > Greg Kroah Hartman in his google tech talk about the kernel
> > (http://www.youtube.com/watch?v=L2SED6sewRw) talked about probably
> > ignore that criteria in the future, I thought the checkpatch.pl script
> > should have an option to ignore checking for long lines.
> >
> > This would help finding the real errors and warnings, because they don't
> > drown in line length warnings.
>
> Instead of adding another command-line option, I'd suggest to just use CHK
> instead of WARN, so this check will be enabled with --strict. I wonder if there
> is already consensus on deprecating the 80-char-rule?
Nope. There's a vocal contingent that doesn't like it though.
An earlier thread and suggested patch below.
http://lkml.org/lkml/2009/12/18/3
next prev parent reply other threads:[~2010-06-13 5:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-12 17:09 Fredrik Gustafsson
2010-06-13 1:04 ` Wolfram Sang
2010-06-13 5:36 ` Joe Perches [this message]
2010-06-13 5:49 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1276407372.1449.33.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=iveqy@iveqy.com \
--cc=linux-kernel@vger.kernel.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®