From: <Claudiu.Beznea@microchip.com>
To: <yang.lee@linux.alibaba.com>, <mchehab@kernel.org>
Cc: <eugen.hristev@collabora.com>, <Nicolas.Ferre@microchip.com>,
<alexandre.belloni@bootlin.com>, <gregkh@linuxfoundation.org>,
<linux-media@vger.kernel.org>, <linux-staging@lists.linux.dev>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next v2] media: atmel: atmel-isc: Use devm_platform_ioremap_resource()
Date: Thu, 16 Mar 2023 11:15:35 +0000 [thread overview]
Message-ID: <12764b50-8eaf-dd9d-a9ff-d2f1b9d35063@microchip.com> (raw)
In-Reply-To: <20230315003009.123827-1-yang.lee@linux.alibaba.com>
On 15.03.2023 02:30, Yang Li wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> According to commit 7945f929f1a7 ("drivers: provide
> devm_platform_ioremap_resource()"), convert platform_get_resource(),
> devm_ioremap_resource() to a single call to use
> devm_platform_ioremap_resource(), as this is exactly what this function
> does.
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
>
> change in v2:
> According to Claudiu's suggestion, make the 'Use' to 'use'in the commit description.
>
> drivers/staging/media/deprecated/atmel/atmel-sama5d2-isc.c | 4 +---
> drivers/staging/media/deprecated/atmel/atmel-sama7g5-isc.c | 4 +---
> 2 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/media/deprecated/atmel/atmel-sama5d2-isc.c b/drivers/staging/media/deprecated/atmel/atmel-sama5d2-isc.c
> index ba0614f981a2..eebb336efce7 100644
> --- a/drivers/staging/media/deprecated/atmel/atmel-sama5d2-isc.c
> +++ b/drivers/staging/media/deprecated/atmel/atmel-sama5d2-isc.c
> @@ -389,7 +389,6 @@ static int atmel_isc_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct isc_device *isc;
> - struct resource *res;
> void __iomem *io_base;
> struct isc_subdev_entity *subdev_entity;
> int irq;
> @@ -403,8 +402,7 @@ static int atmel_isc_probe(struct platform_device *pdev)
> platform_set_drvdata(pdev, isc);
> isc->dev = dev;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - io_base = devm_ioremap_resource(dev, res);
> + io_base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(io_base))
> return PTR_ERR(io_base);
>
> diff --git a/drivers/staging/media/deprecated/atmel/atmel-sama7g5-isc.c b/drivers/staging/media/deprecated/atmel/atmel-sama7g5-isc.c
> index 01ababdfcbd9..beed40fe3f91 100644
> --- a/drivers/staging/media/deprecated/atmel/atmel-sama7g5-isc.c
> +++ b/drivers/staging/media/deprecated/atmel/atmel-sama7g5-isc.c
> @@ -378,7 +378,6 @@ static int microchip_xisc_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct isc_device *isc;
> - struct resource *res;
> void __iomem *io_base;
> struct isc_subdev_entity *subdev_entity;
> int irq;
> @@ -392,8 +391,7 @@ static int microchip_xisc_probe(struct platform_device *pdev)
> platform_set_drvdata(pdev, isc);
> isc->dev = dev;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - io_base = devm_ioremap_resource(dev, res);
> + io_base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(io_base))
> return PTR_ERR(io_base);
>
> --
> 2.20.1.7.g153144c
>
prev parent reply other threads:[~2023-03-16 11:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 0:30 Yang Li
2023-03-16 11:15 ` Claudiu.Beznea [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12764b50-8eaf-dd9d-a9ff-d2f1b9d35063@microchip.com \
--to=claudiu.beznea@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=eugen.hristev@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®