From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932735AbcC3QUv (ORCPT ); Wed, 30 Mar 2016 12:20:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32878 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932119AbcC3QTj (ORCPT ); Wed, 30 Mar 2016 12:19:39 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <1459166340.2751.52.camel@linux.vnet.ibm.com> References: <1459166340.2751.52.camel@linux.vnet.ibm.com> <20160309111814.28811.95697.stgit@warthog.procyon.org.uk> <20160309111939.28811.7952.stgit@warthog.procyon.org.uk> To: Mimi Zohar Cc: dhowells@redhat.com, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 12/12] IMA: Use the the system trusted keyrings instead of .ima_mok [ver #3] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <12766.1459354776.1@warthog.procyon.org.uk> Date: Wed, 30 Mar 2016 17:19:36 +0100 Message-ID: <12767.1459354776@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mimi Zohar wrote: > > +choice > > + prompt "Allow keys to be added to the ima keyrings by userspace?" > > + depends on IMA_APPRAISE > > + depends on INTEGRITY_ASYMMETRIC_KEYS > > + default IMA_NO_ADD_TO_IMA_KEYRINGS > > In this patch, the choice should be between checking just the builtin > trusted keys or both the builtin trusted and secondary keys. The third option I've added is that you can't add to .ima at all. You only get what's included at build time. You don't want that option? > if IMA is enabled, I'm not sure what IMA_NO_ADD_TO_IMA_KEYRINGS means. Oops. that should be IMA_KEYRINGS_COMPILE_LOAD_ONLY. "IMA_NO_ADD_TO_IMA_KEYRINGS" seemed to be phrased too clunkily, but the Kconfig parser warn you about the undefined symbol. > > +config IMA_KEYRINGS_COMPILE_LOAD_ONLY > > + bool "No runtime key addition" > ... > This could be useful for namespacing IMA. You said you didn't want this option above (to quote: In this patch, the choice should be between checking just the builtin trusted keys or both the builtin trusted and secondary keys.) David