mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Scott J. Goldman" <scottjg@vmware.com>
To: Andy Whitcroft <apw@canonical.com>
Cc: linux-kernel@vger.kernel.org, "Scott J. Goldman" <scottjg@vmware.com>
Subject: [PATCH] checkpatch: fix false positive on casting to double pointer
Date: Thu, 17 Jun 2010 13:26:51 -0700	[thread overview]
Message-ID: <1276806411-15176-1-git-send-email-scottjg@vmware.com> (raw)


Signed-off-by: Scott J. Goldman <scottjg@vmware.com>
---
 scripts/checkpatch.pl         |    4 +++-
 tests/t/t9190-double-pointers |    6 ++++++
 2 files changed, 9 insertions(+), 1 deletions(-)
 create mode 100644 tests/t/t9190-double-pointers

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 87bbb8b..687bd6f 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1982,7 +1982,9 @@ sub process {
 					 $op eq '*' or $op eq '/' or
 					 $op eq '%')
 				{
-					if ($ctx =~ /Wx[^WCE]|[^WCE]xW/) {
+					if ($op eq '*' && $cc =~ /^\*/) {
+						# double pointer is ok
+					} elsif ($ctx =~ /Wx[^WCE]|[^WCE]xW/) {
 						ERROR("need consistent spacing around '$op' $at\n" .
 							$hereptr);
 					}
diff --git a/tests/t/t9190-double-pointers b/tests/t/t9190-double-pointers
new file mode 100644
index 0000000..3f3f7f9
--- /dev/null
+++ b/tests/t/t9190-double-pointers
@@ -0,0 +1,6 @@
+pass "foo **x;"
+pass "x = **y;"
+pass "x = (foo **)y;"
+
+err='"(foo ** )" should be "(foo **)"'
+fail	"x = (foo ** )y;"	"$err"
-- 
1.6.0.3


             reply	other threads:[~2010-06-17 20:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-17 20:26 Scott J. Goldman [this message]
2010-06-18 13:15 ` Andy Whitcroft
2010-06-18 13:19   ` Andy Whitcroft
2010-06-18 16:11     ` Scott Goldman
2010-06-18 18:07     ` [PATCH] checkpatch: fix false positives involving __percpu attribute Scott J. Goldman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1276806411-15176-1-git-send-email-scottjg@vmware.com \
    --to=scottjg@vmware.com \
    --cc=apw@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome