Re: [PATCH] tracing: Fix undelared ENOSYS in include/linux/tracepoint.h

[Steven Rostedt <rostedt@goodmis.org>]

On Mon, 2010-06-21 at 11:47 -0400, Mathieu Desnoyers wrote:
> * Steven Rostedt (rostedt@goodmis.org) wrote:
> > On Mon, 2010-06-21 at 19:09 +0800, Wu Zhangjin wrote:
> > > From: Wu Zhangjin <wuzhangjin@gmail.com>
> > > 
> > > The header file include/linux/tracepoint.h may be included without
> > > include/linux/errno.h and then the compiler will fail on building for
> > > undelcared ENOSYS. This patch fixes this problem via including <linux/errno.h>
> > > to include/linux/tracepoint.h.
> > > 
> > 
> > Hi Wu,
> > 
> > I have not hit this. Did you hit this with mips? Does it need to get
> > into 2.6.35 or can it wait till 2.6.36?
> 
> errno.h is included by sched.h, which is included almost everywhere. No
> wonder it took that much time for someone to hit the problem. But given
> it's a simple bug fix, it should fit into the "for-2.6.35" definition,
> although I am no expert in these definitions. ;-)

Usually I would agree. But lately Linus has been very strict in what
goes into 35.

Thus, I would say, it should go into 35 if it breaks a configuration
build of things already in 35. Otherwise, it can wait till 36.

Of course this is an extremely trivial fix, and maybe there's a
configuration already in 35 that we don't know about that this bug can
break. I guess I'll just pull it in for a 35 push.

-- Steve