From: Raffaele Recalcati <lamiaposta71@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Raffaele Recalcati <raffaele.recalcati@bticino.it>,
Andy Whitcroft <apw@canonical.com>,
Andrew Morton <akpm@linux-foundation.org>,
Daniel Walker <dwalker@fifo99.com>, Joe Perches <joe@perches.com>
Subject: [PATCH] scripts: checkpatch.pl
Date: Wed, 23 Jun 2010 11:49:21 +0200 [thread overview]
Message-ID: <1277286561-3448-2-git-send-email-lamiaposta71@gmail.com> (raw)
In-Reply-To: <1277286561-3448-1-git-send-email-lamiaposta71@gmail.com>
From: Raffaele Recalcati <raffaele.recalcati@bticino.it>
I've got a false positive when spaces are present
at the beginning of a line.
So I add this check, obviously outside comments.
This patch is compatible with the actual mainline,
I mean 7e27d6e778cd87b6f2415515d7127eba53fe5d02 commit.
Signed-off-by: Raffaele Recalcati <raffaele.recalcati@bticino.it>
---
scripts/checkpatch.pl | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index a4d7434..315a827 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1433,6 +1433,13 @@ sub process {
WARN("please, no space before tabs\n" . $herevet);
}
+# check for spaces at the beginning of a line.
+ if ($rawline =~ /^\+ / && $rawline !~ /\+ +\*/) {
+ my $herevet = "$here\n" . cat_vet($rawline) . "\n";
+ WARN("please, no space for starting a line, \
+ excluding comments\n" . $herevet);
+ }
+
# check we are in a valid C source file if not then ignore this hunk
next if ($realfile !~ /\.(h|c)$/);
--
1.7.0.4
next prev parent reply other threads:[~2010-06-23 9:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-23 9:49 Raffaele Recalcati
2010-06-23 9:49 ` Raffaele Recalcati [this message]
2010-06-23 19:27 ` Andrew Morton
[not found] ` <AANLkTimYibiMB0wx2LSvj8InY_SSvBcO3AiH-0jdT8OG@mail.gmail.com>
2010-08-17 16:39 ` Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1277286561-3448-2-git-send-email-lamiaposta71@gmail.com \
--to=lamiaposta71@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=dwalker@fifo99.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=raffaele.recalcati@bticino.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome