From: "Henrik Rydberg" <rydberg@euromail.se>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Jiri Kosina <jkosina@suse.cz>, Ping Cheng <pingc@wacom.com>,
Benjamin Tissoires <tissoire@cena.fr>,
Chase Douglas <chase.douglas@canonical.com>,
Rafi Rubin <rafi@seas.upenn.edu>,
Henrik Rydberg <rydberg@euromail.se>
Subject: [PATCH 2/5] input: Use driver hint to compute the evdev buffer size (rev3)
Date: Wed, 23 Jun 2010 13:14:43 +0200 [thread overview]
Message-ID: <1277291686-7153-3-git-send-email-rydberg@euromail.se> (raw)
In-Reply-To: <1277291686-7153-2-git-send-email-rydberg@euromail.se>
Some devices, in particular MT devices, produce a lot of data. This
leads to a high frequency of lost packets in evdev, which by default
uses a fairly small event buffer. Let the drivers hint the average
number of events per packet for the device by calling the
input_set_events_per_packet(), and use that information when computing
the evdev buffer size.
Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
---
drivers/input/evdev.c | 5 ++++-
include/linux/input.h | 17 +++++++++++++++++
2 files changed, 21 insertions(+), 1 deletions(-)
diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c
index 5d84e59..728802f 100644
--- a/drivers/input/evdev.c
+++ b/drivers/input/evdev.c
@@ -11,6 +11,7 @@
#define EVDEV_MINOR_BASE 64
#define EVDEV_MINORS 32
#define EVDEV_MIN_BUFFER_SIZE 64
+#define EVDEV_BUF_PACKETS 8
#include <linux/poll.h>
#include <linux/sched.h>
@@ -51,7 +52,9 @@ static DEFINE_MUTEX(evdev_table_mutex);
static int evdev_compute_buffer_size(struct input_dev *dev)
{
- return EVDEV_MIN_BUFFER_SIZE;
+ int nev = dev->hint_events_per_packet * EVDEV_BUF_PACKETS;
+ nev = max(nev, EVDEV_MIN_BUFFER_SIZE);
+ return roundup_pow_of_two(nev);
}
static void evdev_pass_event(struct evdev_client *client,
diff --git a/include/linux/input.h b/include/linux/input.h
index 20e4eac..9e024b6 100644
--- a/include/linux/input.h
+++ b/include/linux/input.h
@@ -1162,6 +1162,8 @@ struct input_dev {
unsigned long ffbit[BITS_TO_LONGS(FF_CNT)];
unsigned long swbit[BITS_TO_LONGS(SW_CNT)];
+ unsigned int hint_events_per_packet;
+
unsigned int keycodemax;
unsigned int keycodesize;
void *keycode;
@@ -1439,6 +1441,21 @@ static inline void input_mt_slot(struct input_dev *dev, int slot)
void input_set_capability(struct input_dev *dev, unsigned int type, unsigned int code);
+/**
+ * input_set_events_per_packet - tell handlers about the driver event rate
+ * @dev: the input device used by the driver
+ * @nev: the average number of events between calls to input_sync()
+ *
+ * If the event rate sent from a device is unusually large, use this
+ * function to set the expected event rate. This will allow handlers
+ * to set up an approriate buffer size for the event stream, in order
+ * to minimize information loss.
+ */
+static inline void input_set_events_per_packet(struct input_dev *dev, int nev)
+{
+ dev->hint_events_per_packet = nev;
+}
+
static inline void input_set_abs_params(struct input_dev *dev, int axis, int min, int max, int fuzz, int flat)
{
dev->absmin[axis] = min;
--
1.6.3.3
next prev parent reply other threads:[~2010-06-23 11:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-23 11:14 [PATCH 0/4] input: evdev: Dynamic buffers (rev5) Henrik Rydberg
2010-06-23 11:14 ` [PATCH 1/5] input: evdev: Convert to dynamic event buffer (rev5) Henrik Rydberg
2010-06-23 11:14 ` Henrik Rydberg [this message]
2010-06-23 11:14 ` [PATCH 3/5] input: bcm5974: Set the average number of events per MT event packet Henrik Rydberg
2010-06-23 11:14 ` [PATCH 4/5] hid-input: Use a larger event buffer for MT devices Henrik Rydberg
2010-06-23 11:14 ` [PATCH 5/5] input: evdev: Never leave the client buffer empty after write Henrik Rydberg
2010-06-23 14:20 ` [PATCH 4/5] hid-input: Use a larger event buffer for MT devices Jiri Kosina
2010-06-23 16:54 ` [PATCH 2/5] input: Use driver hint to compute the evdev buffer size (rev3) Ping Cheng
2010-06-23 17:07 ` Henrik Rydberg
2010-06-23 17:12 ` Dmitry Torokhov
2010-06-23 17:27 ` Henrik Rydberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1277291686-7153-3-git-send-email-rydberg@euromail.se \
--to=rydberg@euromail.se \
--cc=chase.douglas@canonical.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pingc@wacom.com \
--cc=rafi@seas.upenn.edu \
--cc=tissoire@cena.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®