From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753058Ab0F2DHe (ORCPT ); Mon, 28 Jun 2010 23:07:34 -0400 Received: from mail-qy0-f174.google.com ([209.85.216.174]:56384 "EHLO mail-qy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751680Ab0F2DHc (ORCPT ); Mon, 28 Jun 2010 23:07:32 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:content-type:date:message-id:mime-version :x-mailer:content-transfer-encoding; b=mQQI4uc68J++a2K2Fy23rM/q4u9hOlUDb85mjZzfidMeYWVgf35llEamCJ4FT7nj2F QjV9UAFNNdXqNfDj5zEi8Ewad2tAAsyEod/T6P3z0yAFFuFCiscCYTN81WWM/CuqgKiQ lKJoFbHaGdhsjJKANgI4VaEbC52mVNa/tI0Cc= Subject: [PATCH] asus-laptop: fix a memory leak in asus_laptop_get_info error path From: Axel Lin To: linux-kernel Cc: Corentin Chary , Matthew Garrett , Len Brown , Alan Jenkins , acpi4asus-user@lists.sourceforge.net, platform-driver-x86@vger.kernel.org Content-Type: text/plain Date: Tue, 29 Jun 2010 11:09:47 +0800 Message-Id: <1277780987.5478.2.camel@mola> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The callers of write_acpi_int_ret() pass ACPI_ALLOCATE_BUFFER, the caller must kfree the returned buffer if AE_OK is returned. This patch adds a missing kfree(buffer.pointer) before return -ENOMEM if kstrdup fail. Signed-off-by: Axel Lin --- drivers/platform/x86/asus-laptop.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c index 71db2ef..3d76c6a 100644 --- a/drivers/platform/x86/asus-laptop.c +++ b/drivers/platform/x86/asus-laptop.c @@ -1397,8 +1397,10 @@ static int asus_laptop_get_info(struct asus_laptop *asus) } } asus->name = kstrdup(string, GFP_KERNEL); - if (!asus->name) + if (!asus->name) { + kfree(buffer.pointer); return -ENOMEM; + } if (*string) pr_notice(" %s model detected\n", string); -- 1.5.4.3