From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753166AbdJLQZ5 (ORCPT ); Thu, 12 Oct 2017 12:25:57 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:33385 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751517AbdJLQZy (ORCPT ); Thu, 12 Oct 2017 12:25:54 -0400 X-AuditID: b6c32a38-d89ff70000001124-5c-59df978e3428 From: Bartlomiej Zolnierkiewicz To: Christophe JAILLET Cc: tj@kernel.org, viro@zeniv.linux.org.uk, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] video: fbdev: Fix an errro handling path in 'au1200fb_drv_probe()' Date: Thu, 12 Oct 2017 18:25:48 +0200 Message-id: <12781513.OMEBNrce0f@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20170912053930.18931-1-christophe.jaillet@wanadoo.fr> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrBIsWRmVeSWpSXmKPExsWy7bCmnm7f9PuRBqv3GVlsPTiX1eLK1/ds FltvSVuc6PvAanF51xw2i1/LjzJanP97nNWB3WPTqk42j/vdx5k8Pm+S8/h8dz2rx6Ynb5kC WKO4bFJSczLLUov07RK4Mg608xY846rYMO8CewPjFY4uRg4OCQETif+r6rsYuTiEBHYwSkz8 u5UJwvnOKLH76HzWLkZOsKInF08xQiR2M0osfb6OBcL5yijx6H4DG0gVm4CVxMT2VYwgtoiA mcTcvtvMIDazwGpGiZZD4SC2sECkxJq3B5lAbBYBVYn5by6B1fAKaEm8Pz0TbI6ogJfEln3t YDWcAs4St958YIKoEZT4MfkeC8RMeYl9+6eyQtg6EmePrQO7TkLgAJvEnmfPmCHOdpG4e+E6 I4QtLPHq+BZ2iJ+lJS4dtYUIT2eU2P5bAqJ3M6PEqt0T2CES1hKHj1+EWsAn8e5rDytEL69E R5sQRImHxNpL16DGO0rcfrgTrFVIYBqjxJJNHBMYZWchOXsWkrNnITl7ASPzKkax1ILi3PTU YsMCE73ixNzi0rx0veT83E2M4PSgZbGDcc85n0OMAhyMSjy8AlX3I4VYE8uKK3MPMUpwMCuJ 8Hp0AoV4UxIrq1KL8uOLSnNSiw8xSnOwKInziq6/FiEkkJ5YkpqdmlqQWgSTZeLglGpgTKy5 U7I53svrQKFz5IVmy0VH5DYrdJgGqX+T8LcKMq4PvKfd/j6fd0m2rYCYSHGQh3liUJf0U1tj RT3vn2ET63RrPzD9CO0W/L/H+eKx7x9Wik9tjo/Utr8n2eTGsbmu3PePw5/3DMKzV82Nrd/h p2R0Mf1n+c1SCaP3PayfY7SOvuNZeFKJpTgj0VCLuag4EQB7HImXCwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrCLMWRmVeSWpSXmKPExsVy+t9jAd2+6fcjDebMlLDYenAuq8WVr+/Z LLbekrY40feB1eLyrjlsFr+WH2W0OP/3OKsDu8emVZ1sHve7jzN5fN4k5/H57npWj01P3jIF sEZx2aSk5mSWpRbp2yVwZRxo5y14xlWxYd4F9gbGKxxdjJwcEgImEk8unmLsYuTiEBLYySix YdcDZgjnK6PE8oeL2EGq2ASsJCa2r2IEsUUEzCTm9t0GK2IWWM0o8aHlJjNIQlggUmLN24NM IDaLgKrE/DeXwOK8AloS70/PZAOxRQW8JLbsawer4RRwlrj15gMTxLYZjBL/zl5lgmgQlPgx +R4LiM0sIC+xb/9UVghbS2L9zuNMExj5ZyEpm4WkbBaSsgWMzKsYJVMLinPTc4uNCgzzUsv1 ihNzi0vz0vWS83M3MQLDetthrb4djPeXxB9iFOBgVOLhFai6HynEmlhWXJl7iFGCg1lJhNej EyjEm5JYWZValB9fVJqTWnyIUZqDRUmc93besUghgfTEktTs1NSC1CKYLBMHp1QDY81dmzV5 v1ac09hr52XH5HTd94bVo4xlt38z8sSfYC28JGX4cMo7vQPBMw04f2/JrWa7uHVVpc8U2/0K VdpHF3vNkixrFtmxLZevZMeWnWd9brtMUOj7VOjFd/aBHfvOzpfl93OOLW1f8uKqgXrV6++C vz7du5pl3a8heaNzz7e+b+9ObZ9ff0WJpTgj0VCLuag4EQAGDW1IZwIAAA== X-CMS-MailID: 20171012162550epcas1p194bdd8f4d04f5483022c40e8e2239e3c X-Msg-Generator: CA X-Sender-IP: 182.195.42.142 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 101P X-CMS-RootMailID: 20170912054234epcas4p2afadfa32766d7a186c00f1fdc568c7bf X-RootMTR: 20170912054234epcas4p2afadfa32766d7a186c00f1fdc568c7bf References: <20170912053930.18931-1-christophe.jaillet@wanadoo.fr> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ added dri-devel ML to cc: ] On Tuesday, September 12, 2017 07:39:30 AM Christophe JAILLET wrote: > If 'dmam_alloc_attrs()' fails, we must go through the error handling code, > as done elsewhere in this function. Otherwise, there is a resource leak. > > Signed-off-by: Christophe JAILLET > --- > I'm also puzzled by the 'framebuffer_alloc()' call a few lines above. > 'ret' is known to be 0 at this point. I guess that -ENOMEM should also be > returned. Yes, moreover the "failed:" error path is incomplete (please take a look at au1200fb_drv_remove() for comparison) and needs to be fixed. Could you please take care of it? > --- > drivers/video/fbdev/au1200fb.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/au1200fb.c b/drivers/video/fbdev/au1200fb.c > index 5f04b4096c42..99d6cfb168b5 100644 > --- a/drivers/video/fbdev/au1200fb.c > +++ b/drivers/video/fbdev/au1200fb.c > @@ -1701,7 +1701,8 @@ static int au1200fb_drv_probe(struct platform_device *dev) > if (!fbdev->fb_mem) { > print_err("fail to allocate frambuffer (size: %dK))", > fbdev->fb_len / 1024); > - return -ENOMEM; > + ret = -ENOMEM; > + goto failed; > } > > /* Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics